Re: RFR JDK-8143330: No appropriate CCC request for two new protected methods added in JDK9b93 by JDK-8141132

2015-11-23 Thread Tobias Hartmann 
Hi,

looks good to me.

Best,
Tobias

On 20.11.2015 19:41, Xueming Shen wrote:
> 
> I missed the override version in StringBuffer.java, thanks
> Tobias for catching it.
> 
> http://cr.openjdk.java.net/~sherman/8143553
> https://bugs.openjdk.java.net/browse/JDK-8143553
> 
> I did re-generate the api doc, but still missed it :-(
> 
> Thanks,
> Sherman
> 
> 
> On 11/19/2015 12:50 PM, Xueming Shen wrote:
>> Thanks Joe, Alan! The synopsis has been updated accordingly.
>>
>> On 11/19/2015 12:43 PM, Alan Bateman wrote:
>>>
>>>
>>> On 19/11/2015 20:39, joe darcy wrote:
 Looks good Sherman; thanks,

>>> Looks okay to me too. We should fix the synopsis on the JIRA issue or at 
>>> least put a better message in the change-set comment.
>>>
>>> -Alan.
>>
>

Re: RFR JDK-8143330: No appropriate CCC request for two new protected methods added in JDK9b93 by JDK-8141132

2015-11-20 Thread Tobias Hartmann 
Hi Sherman,

On 19.11.2015 21:27, Xueming Shen wrote:
> Hi
> 
> Please help review the change for 8143330.
> 
> Issue: https://bugs.openjdk.java.net/browse/JDK-8143330
> webrev: http://cr.openjdk.java.net/~sherman/8143330/webrev

What about this

733 protected synchronized void getBytes(byte dst[], int dstBegin, byte 
coder) {
734 super.getBytes(dst, dstBegin, coder);
735 }

which was added to StringBuffer?

Best,
Tobias

> Cause: two implementation methods ABS.getBytes/initBytes were
> mistakenly declared as "protected" and exposed to the public. Both
> should be package private.
> 
> Thanks,
> Sherman

Re: RFR JDK-8143330: No appropriate CCC request for two new protected methods added in JDK9b93 by JDK-8141132

2015-11-20 Thread Xueming Shen 


I missed the override version in StringBuffer.java, thanks
Tobias for catching it.

http://cr.openjdk.java.net/~sherman/8143553
https://bugs.openjdk.java.net/browse/JDK-8143553

I did re-generate the api doc, but still missed it :-(

Thanks,
Sherman


On 11/19/2015 12:50 PM, Xueming Shen wrote:

Thanks Joe, Alan! The synopsis has been updated accordingly.

On 11/19/2015 12:43 PM, Alan Bateman wrote:



On 19/11/2015 20:39, joe darcy wrote:

Looks good Sherman; thanks,


Looks okay to me too. We should fix the synopsis on the JIRA issue or at least 
put a better message in the change-set comment.

-Alan.

Re: RFR JDK-8143330: No appropriate CCC request for two new protected methods added in JDK9b93 by JDK-8141132

2015-11-19 Thread Xueming Shen 

Thanks Joe, Alan! The synopsis has been updated accordingly.

On 11/19/2015 12:43 PM, Alan Bateman wrote:



On 19/11/2015 20:39, joe darcy wrote:

Looks good Sherman; thanks,


Looks okay to me too. We should fix the synopsis on the JIRA issue or at least 
put a better message in the change-set comment.

-Alan.

Re: RFR JDK-8143330: No appropriate CCC request for two new protected methods added in JDK9b93 by JDK-8141132

2015-11-19 Thread Alan Bateman 



On 19/11/2015 20:39, joe darcy wrote:

Looks good Sherman; thanks,

Looks okay to me too. We should fix the synopsis on the JIRA issue or at 
least put a better message in the change-set comment.


-Alan.

Re: RFR JDK-8143330: No appropriate CCC request for two new protected methods added in JDK9b93 by JDK-8141132

2015-11-19 Thread joe darcy 

Looks good Sherman; thanks,

-Joe

On 11/19/2015 12:27 PM, Xueming Shen wrote:

Hi

Please help review the change for 8143330.

Issue: https://bugs.openjdk.java.net/browse/JDK-8143330
webrev: http://cr.openjdk.java.net/~sherman/8143330/webrev

Cause: two implementation methods ABS.getBytes/initBytes were
mistakenly declared as "protected" and exposed to the public. Both
should be package private.

Thanks,
Sherman