Re: Review Request: 7193683: Cleanup Warning in java.sql package
Looks good!
While you are there maybe correct indentations and tab - spaces, e.g.:
531 } catch(Throwable t) {
532 // Do nothing
533 }
But here maybe better:
531 } catch(Throwable t) {} // Do nothing
-Ulf
Am 29.08.2012 07:29, schrieb Dan Xu:
I made a simple fix to clean up build warnings in java.sql package. The change can be reviewed at
http://cr.openjdk.java.net/~dxu/7193683/webrev.01/. Thanks!
-Dan
Re: Review Request: 7193683: Cleanup Warning in java.sql package
This looks fine. Dan, I will commit this for you Thursday Best Lance On Aug 29, 2012, at 1:29 AM, Dan Xu wrote: I made a simple fix to clean up build warnings in java.sql package. The change can be reviewed at http://cr.openjdk.java.net/~dxu/7193683/webrev.01/. Thanks! -Dan Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
Review Request: 7193683: Cleanup Warning in java.sql package
I made a simple fix to clean up build warnings in java.sql package. The change can be reviewed at http://cr.openjdk.java.net/~dxu/7193683/webrev.01/. Thanks! -Dan
