Re: Review Request: JDK-8193192: jdeps --generate-module-info does not look at module path

2017-12-12 Thread Daniel Fuchs

Hi Mandy,

I have seen nothing obviously wrong with this patch.
Using tokens instead of a bunch of boolean variables is a
nice simplification IMO.

best regards,

-- daniel

On 07/12/2017 17:17, mandy chung wrote:
jdeps currently finds modules from the module path for analysis based on 
the value specified via --add-modules option.  When the input classes 
depend on a module on the given module path, it will report missing 
dependences until the module is specified in --add-modules option.  This 
fixes this issue and jdeps should look at the modules on the module path 
when analyzing classes (except jdeps -m option).


http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8193192/webrev.00

thanks
Mandy




Review Request: JDK-8193192: jdeps --generate-module-info does not look at module path

2017-12-07 Thread mandy chung
jdeps currently finds modules from the module path for analysis based on 
the value specified via --add-modules option.  When the input classes 
depend on a module on the given module path, it will report missing 
dependences until the module is specified in --add-modules option.  This 
fixes this issue and jdeps should look at the modules on the module path 
when analyzing classes (except jdeps -m option).


http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8193192/webrev.00

thanks
Mandy