Re: Review needed: 8004374 : Fwd: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-10 Thread Lance Andersen - Oracle
Hi Frank,

As I explained in one of my earlier emails,  tests that require a database will 
not be added to jtreg.  I have a unit test suite which i use for that but that 
is not external


Best
Lance
On Dec 10, 2012, at 2:44 AM, Frank Ding wrote:

 Hi Lance,
  The code refactory looks good.  By the way, the newly added unit test is not 
 jtreg test case?
 
 Best regards,
 Frank
 
 On 12/5/2012 4:38 AM, Lance Andersen - Oracle wrote:
 All,
 
 Attached is the patch for:  8004374 based off the issue that Frank reported.
 
 for http://cr.openjdk.java.net/~lancea/8004374/webrev.00/ 
 http://cr.openjdk.java.net/%7Elancea/8004374/webrev.00/
 
 The TCK, SQE and the JDBC Unit Tests run clean.  I added a new Unit Test to 
 validate the issue.
 
 Frank, I did not use your fix as I was able to clean the code up a bit more 
 and get rid of more crud while addressing it.  It is similar though.
 
 Best
 Lance
 
 http://oracle.com/us/design/oracle-email-sig-198324.gif
 
 
 http://oracle.com/us/design/oracle-email-sig-198324.gif
 http://oracle.com/us/design/oracle-email-sig-198324.gifLance Andersen| 
 Principal Member of Technical Staff | +1.781.442.2037
 Oracle Java Engineering
 1 Network Drive
 Burlington, MA 01803
 lance.ander...@oracle.com mailto:lance.ander...@oracle.com
 
 
 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com



Re: Review needed: 8004374 : Fwd: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-09 Thread Frank Ding

Hi Lance,
  The code refactory looks good.  By the way, the newly added unit test 
is not jtreg test case?


Best regards,
Frank

On 12/5/2012 4:38 AM, Lance Andersen - Oracle wrote:

All,

Attached is the patch for:  8004374 based off the issue that Frank 
reported.


 for http://cr.openjdk.java.net/~lancea/8004374/webrev.00/ 
http://cr.openjdk.java.net/%7Elancea/8004374/webrev.00/


The TCK, SQE and the JDBC Unit Tests run clean.  I added a new Unit 
Test to validate the issue.


Frank, I did not use your fix as I was able to clean the code up a bit 
more and get rid of more crud while addressing it.  It is similar though.


Best
Lance

http://oracle.com/us/design/oracle-email-sig-198324.gif


http://oracle.com/us/design/oracle-email-sig-198324.gif
http://oracle.com/us/design/oracle-email-sig-198324.gifLance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037

Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com mailto:lance.ander...@oracle.com