Re: RFR 8234362: k_standard.c is not needed and should be removed (was: Re: _IEEE_LIBM targets and __kernel_standard)

[Andrew Haley]

On 11/18/19 9:49 PM, Florian Weimer wrote:
> I think the file should just be removed.
> 
> Bug: 
> Webrev: 
> 
> As usual, I'll need a sponsor for this.

This is OK. How many patches have you done now? maybe it's time to
give you commit access.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. 
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

RFR 8234362: k_standard.c is not needed and should be removed (was: Re: _IEEE_LIBM targets and __kernel_standard)

[Florian Weimer]

* Florian Weimer:

> __kernel_standard in src/java.base/share/native/libfdlibm/k_standard.c
> is built for _IEEE_LIBM targets as well, but it appears superfluous
> there.
>
> In noticed this because GCC 10 flags an uninitialized variable in this
> code:
>
> …/src/java.base/share/native/libfdlibm/k_standard.c: In function 
> '__j__kernel_standard':
> …/src/java.base/share/native/libfdlibm/k_standard.c:743:19: error: 
> 'exc.retval' may be used uninitialized in this function 
> [-Werror=maybe-uninitialized]
>   743 | return exc.retval;
>   |~~~^~~
>
> Rather than debating whether this warning is reasonableor not, I would
> suggest to #ifdef out this code for _IEEE_LIBM targets (are there any
> else left?).

I think the file should just be removed.

Bug: 
Webrev: 

As usual, I'll need a sponsor for this.

Thanks,
Florian

_IEEE_LIBM targets and __kernel_standard

[Florian Weimer]

__kernel_standard in src/java.base/share/native/libfdlibm/k_standard.c
is built for _IEEE_LIBM targets as well, but it appears superfluous
there.

In noticed this because GCC 10 flags an uninitialized variable in this
code:

…/src/java.base/share/native/libfdlibm/k_standard.c: In function 
'__j__kernel_standard':
…/src/java.base/share/native/libfdlibm/k_standard.c:743:19: error: 'exc.retval' 
may be used uninitialized in this function [-Werror=maybe-uninitialized]
  743 | return exc.retval;
  |~~~^~~

Rather than debating whether this warning is reasonableor not, I would
suggest to #ifdef out this code for _IEEE_LIBM targets (are there any
else left?).

Thanks,
Florian