Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.
This change was integrated prematurely. I've rolled it back in the jdk7/tl/jdk repository. If you've already pulled it into a local repository then you can remove it using the hg strip command, which is part of the mq extension. Your tip changeset should be: changeset: 1563:5cd12b68d09b user:alanb date:Thu Aug 20 08:48:29 2009 +0100 summary: 6866804: (file) Path calls checkPermission insteadof checkXXX (sol) - Mark
Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.
Hi Mark, On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: > This change was integrated prematurely. I've rolled it back in the > jdk7/tl/jdk repository. If at all possible, please don't do this. It plays havoc with already checked out repos and/or automatic clones/backups. You force people to recreate their local repos if you purge a commit that was already public like this. Could you use a normal hg backout instead in the future? That will make sure the integrity of the repo isn't compromised. Thanks, Mark
Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.
2009/8/21 Mark Wielaard : > Hi Mark, > > On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: >> This change was integrated prematurely. I've rolled it back in the >> jdk7/tl/jdk repository. > > If at all possible, please don't do this. It plays havoc with already > checked out repos and/or automatic clones/backups. You force people to > recreate their local repos if you purge a commit that was already public > like this. Could you use a normal hg backout instead in the future? That > will make sure the integrity of the repo isn't compromised. > It would be much cleaner to just do a commit reversing the patch (mjw, is that what you mean by a backout or something else?) I really don't like the idea of sanitising the repos to remove all mistakes and there's also no guarantee everyone will do this and push it in every forest. > Thanks, > > Mark > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.
Hi Andrew, On Fri, 2009-08-21 at 20:35 +0100, Andrew John Hughes wrote: > 2009/8/21 Mark Wielaard : > > On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: > >> This change was integrated prematurely. I've rolled it back in the > >> jdk7/tl/jdk repository. > > > > If at all possible, please don't do this. It plays havoc with already > > checked out repos and/or automatic clones/backups. You force people to > > recreate their local repos if you purge a commit that was already public > > like this. Could you use a normal hg backout instead in the future? That > > will make sure the integrity of the repo isn't compromised. > > > It would be much cleaner to just do a commit reversing the patch (mjw, > is that what you mean by a backout or something else?) Yes. "hg backout" creates a reverse changeset that "cancels out" an earlier commit (but does so in a way that keeps the integrity of repository, plus the whole history). See also: hg backout --help > I really don't like the idea of sanitising the repos to remove all > mistakes and there's also no guarantee everyone will do this and push > it in every forest. > > > Thanks, > > > > Mark
Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.
2009/8/22 Mark Wielaard : > Hi Andrew, > > On Fri, 2009-08-21 at 20:35 +0100, Andrew John Hughes wrote: >> 2009/8/21 Mark Wielaard : >> > On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: >> >> This change was integrated prematurely. I've rolled it back in the >> >> jdk7/tl/jdk repository. >> > >> > If at all possible, please don't do this. It plays havoc with already >> > checked out repos and/or automatic clones/backups. You force people to >> > recreate their local repos if you purge a commit that was already public >> > like this. Could you use a normal hg backout instead in the future? That >> > will make sure the integrity of the repo isn't compromised. >> > >> It would be much cleaner to just do a commit reversing the patch (mjw, >> is that what you mean by a backout or something else?) > > Yes. "hg backout" creates a reverse changeset that "cancels out" an > earlier commit (but does so in a way that keeps the integrity of > repository, plus the whole history). See also: hg backout --help > >> I really don't like the idea of sanitising the repos to remove all >> mistakes and there's also no guarantee everyone will do this and push >> it in every forest. >> >> > Thanks, >> > >> > Mark > > Ah, so it autocreates what I was talking about. Cheers, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be. (also reviewed by ksaks, ryano)
Changeset: 4ec7d1890538 Author:lancea Date: 2009-08-20 19:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ec7d1890538 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be. (also reviewed by ksaks, ryano) Reviewed-by: valeriep + src/share/classes/com/sun/rowset/RowSetFactoryImpl.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java + src/share/classes/javax/sql/rowset/RowSetFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java
