review request: 8015340: remove erroneous @since tag

2013-09-12 Thread Lance Andersen - Oracle
Looking for a reviewer for this trivial fix:


 hg diff PreparedStatement.java 
diff -r 262a625809fd src/share/classes/java/sql/PreparedStatement.java
--- a/src/share/classes/java/sql/PreparedStatement.java Thu Sep 12 01:47:05 
2013 -0700
+++ b/src/share/classes/java/sql/PreparedStatement.java Thu Sep 12 11:18:13 
2013 -0400
@@ -954,7 +954,6 @@
  * the JDBC driver does not support this data type
  * @see Types
  *
- * @since 1.6
  */
 void setObject(int parameterIndex, Object x, int targetSqlType, int 
scaleOrLength)
 throws SQLException;



This method dates back to JDBC 1.0.  Looks like when the javadocs were updated 
for JDBC 4.0, the IEC team accidentally added the @since 1.6. 

Best
Lance

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com



Re: review request: 8015340: remove erroneous @since tag

2013-09-12 Thread Joe Darcy

Look fine Lance; cheers,

-Joe

On 09/12/2013 08:21 AM, Lance Andersen - Oracle wrote:

Looking for a reviewer for this trivial fix:


  hg diff PreparedStatement.java
diff -r 262a625809fd src/share/classes/java/sql/PreparedStatement.java
--- a/src/share/classes/java/sql/PreparedStatement.java Thu Sep 12 01:47:05 
2013 -0700
+++ b/src/share/classes/java/sql/PreparedStatement.java Thu Sep 12 11:18:13 
2013 -0400
@@ -954,7 +954,6 @@
   * the JDBC driver does not support this data type
   * @see Types
   *
- * @since 1.6
   */
  void setObject(int parameterIndex, Object x, int targetSqlType, int 
scaleOrLength)
  throws SQLException;



This method dates back to JDBC 1.0.  Looks like when the javadocs were updated 
for JDBC 4.0, the IEC team accidentally added the @since 1.6.

Best
Lance

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com