Integrated: 8333962: Obsolete OldSize
On Tue, 11 Jun 2024 08:17:02 GMT, Albert Mingkun Yang wrote: > Obsolete OldSize and related code. An internal variable `OldSize` is kept to > capture the capacity of old-gen size. This pull request has now been integrated. Changeset: c94af6f9 Author:Albert Mingkun Yang URL: https://git.openjdk.org/jdk/commit/c94af6f943c179553d1827550847b93491d47506 Stats: 192 lines in 15 files changed: 7 ins; 168 del; 17 mod 8333962: Obsolete OldSize Reviewed-by: dholmes, zgu - PR: https://git.openjdk.org/jdk/pull/19647
Re: RFR: 8333962: Obsolete OldSize [v3]
On Mon, 17 Jun 2024 14:30:30 GMT, Albert Mingkun Yang wrote: >> Obsolete OldSize and related code. An internal variable `OldSize` is kept to >> capture the capacity of old-gen size. > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains one additional > commit since the last revision: > > obsolete-old-size Tests pass. Thanks for review. - PR Comment: https://git.openjdk.org/jdk/pull/19647#issuecomment-2173767317
Re: RFR: 8333962: Obsolete OldSize [v2]
On Fri, 14 Jun 2024 10:19:47 GMT, Albert Mingkun Yang wrote: >> Obsolete OldSize and related code. An internal variable `OldSize` is kept to >> capture the capacity of old-gen size. > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The pull request now contains one commit: > > obsolete-old-size Synced with master. Running some tests before merging. - PR Comment: https://git.openjdk.org/jdk/pull/19647#issuecomment-2173573858
Re: RFR: 8333962: Obsolete OldSize [v3]
> Obsolete OldSize and related code. An internal variable `OldSize` is kept to > capture the capacity of old-gen size. Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: obsolete-old-size - Changes: - all: https://git.openjdk.org/jdk/pull/19647/files - new: https://git.openjdk.org/jdk/pull/19647/files/3e820b6f..a27f5172 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19647&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19647&range=01-02 Stats: 1483 lines in 67 files changed: 966 ins; 310 del; 207 mod Patch: https://git.openjdk.org/jdk/pull/19647.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19647/head:pull/19647 PR: https://git.openjdk.org/jdk/pull/19647
Re: RFR: 8333962: Obsolete OldSize [v2]
On Mon, 17 Jun 2024 13:25:00 GMT, Zhengyu Gu wrote: >> Albert Mingkun Yang has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains one commit: >> >> obsolete-old-size > > src/hotspot/share/gc/shared/genArguments.hpp line 36: > >> 34: extern size_t MaxOldSize; >> 35: >> 36: extern size_t OldSize; > > Any reason we still want to keep `OldSize` variable? becase GCs really care > about are `init`, `min` and `max` values. The concept of "initial old-gen size" will always be there. If `OldSize` is removed, all readers need to be updated to `InitialHeapSize - NewSize`. It's not obvious that is definitely better/more readable. - PR Review Comment: https://git.openjdk.org/jdk/pull/19647#discussion_r1642885640
Re: RFR: 8333962: Obsolete OldSize [v2]
On Sat, 15 Jun 2024 05:09:49 GMT, David Holmes wrote: >> Albert Mingkun Yang has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains one commit: >> >> obsolete-old-size > > src/hotspot/share/runtime/arguments.cpp line 37: > >> 35: #include "gc/shared/gcArguments.hpp" >> 36: #include "gc/shared/gcConfig.hpp" >> 37: #include "gc/shared/genArguments.hpp" > > Why is this needed? `Arguments::set_heap_size` accesses `OldSize`, which is declared in this header. - PR Review Comment: https://git.openjdk.org/jdk/pull/19647#discussion_r1640921256
Re: RFR: 8333962: Obsolete OldSize [v2]
> Obsolete OldSize and related code. An internal variable `OldSize` is kept to > capture the capacity of old-gen size. Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: obsolete-old-size - Changes: https://git.openjdk.org/jdk/pull/19647/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19647&range=01 Stats: 192 lines in 15 files changed: 7 ins; 168 del; 17 mod Patch: https://git.openjdk.org/jdk/pull/19647.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19647/head:pull/19647 PR: https://git.openjdk.org/jdk/pull/19647
RFR: 8333962: Obsolete OldSize
Obsolete OldSize and related code. An internal variable `OldSize` is kept to capture the capacity of old-gen size. - Commit messages: - obsolete-old-size Changes: https://git.openjdk.org/jdk/pull/19647/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19647&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333962 Stats: 193 lines in 15 files changed: 8 ins; 168 del; 17 mod Patch: https://git.openjdk.org/jdk/pull/19647.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19647/head:pull/19647 PR: https://git.openjdk.org/jdk/pull/19647
Re: [jdk22] RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
On Thu, 18 Jan 2024 15:20:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to disable core file generation in > java/foreign/critical/TestCriticalUpcall.java. Marked as reviewed by ayang (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/90#pullrequestreview-1829973047
Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale
On Fri, 9 Jun 2023 22:17:39 GMT, Naoto Sato wrote: > This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where > aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the > in-house cache with WeakHashMap, and removed the Key class as it is no longer > needed (thus the original NPE will no longer be possible). Also with the new > JMH test case, it gains some performance improvement: > > (w/o fix) > > Benchmark Mode Cnt Score Error Units > LocaleCache.testForLanguageTag avgt 20 5781.275 ± 569.580 ns/op > LocaleCache.testLocaleOfavgt 20 62564.079 ± 406.697 ns/op > > (w/ fix) > Benchmark Mode Cnt Score Error Units > LocaleCache.testForLanguageTag avgt 20 4801.175 ± 371.830 ns/op > LocaleCache.testLocaleOfavgt 20 60394.652 ± 352.471 ns/op test/hotspot/jtreg/gc/TestAllocHumongousFragment.java line 180: > 178: */ > 179: > 180: /* Could you move this block a few lines above (e.g. next to the block of `id=iu-aggressive`) so that similar tests are grouped together? - PR Review Comment: https://git.openjdk.org/jdk/pull/14404#discussion_r1226617033
