Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test
On Wed, 19 Jun 2024 12:47:33 GMT, Fernando Guallini wrote: > The following test: > **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is > currently marked to be run manually because user inputs are required in the > console, but instead it can be automated by providing a custom inputStream to > System.in in the actual test to simulate sequential user input. > > In addition, this patch is removing the test from the problemList as it > passes, and from manual test list. Please, I would need a review on this PR - PR Comment: https://git.openjdk.org/jdk/pull/19790#issuecomment-2191674728
RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test
The following test: **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is currently marked to be run manually because user inputs are required in the console, but instead it can be automated by providing a custom inputStream to System.in in the actual test to simulate sequential user input. In addition, this patch is removing the test from the problemList as it passes, and from manual test list. - Commit messages: - test TextCallbackHandler/Default.java is automated Changes: https://git.openjdk.org/jdk/pull/19790/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19790=00 Issue: https://bugs.openjdk.org/browse/JDK-8334562 Stats: 50 lines in 3 files changed: 29 ins; 2 del; 19 mod Patch: https://git.openjdk.org/jdk/pull/19790.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19790/head:pull/19790 PR: https://git.openjdk.org/jdk/pull/19790
Withdrawn: 8329335: HttpsURLConnectionTest fails due to network firewall rules
On Mon, 17 Jun 2024 09:16:45 GMT, Fernando Guallini wrote: > Since HttpsURLConnectionTest attempts to reach external servers, it can fail > if run on hosts without outbound traffic allowed. Therefore, it should not be > executed in CI pipelines but rather manually on a host with no firewall rules > preventing egress traffic. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/19745
RFR: 8329335: HttpsURLConnectionTest fails due to network firewall rules
Since HttpsURLConnectionTest attempts to reach external servers, it can fail if run on hosts without outbound traffic allowed. Therefore, it should not be executed in CI pipelines but rather manually on a host with no firewall rules preventing egress traffic. - Commit messages: - test should be run manually to avoid proxy problems Changes: https://git.openjdk.org/jdk/pull/19745/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19745=00 Issue: https://bugs.openjdk.org/browse/JDK-8329335 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19745.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19745/head:pull/19745 PR: https://git.openjdk.org/jdk/pull/19745
