Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v4]
On Sat, 27 Apr 2024 01:45:47 GMT, Jaikiran Pai wrote: >> Jin Kwon has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8330686: Fix typos in the DatabaseMetaData javadoc >> >> Reviewed-by: jpai, lancea, iris > > Yes, the PR has been merged and the changes are now part of the JDK. @jaikiran I do love you. Thank you. - PR Comment: https://git.openjdk.org/jdk/pull/18860#issuecomment-2080320659
Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v4]
On Sat, 27 Apr 2024 01:09:58 GMT, Jaikiran Pai wrote: >> Jin Kwon has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8330686: Fix typos in the DatabaseMetaData javadoc >> >> Reviewed-by: jpai, lancea, iris > > Hello Jin, once a PR is approved, unless there are additional review comments > to address, it's a good idea not to update/change the PR. > > In this case, it appears that you only updated the commit message to include > the `Reviewed-By` line. Contributions to the JDK repo these days use bots > which automatically add the `Reviewed-By` line when the PR is actually being > integrated. We used to previously (before migrating to GitHub pull requests) > expect the contributors to add that line themselves, but that's no longer the > case. > > I have reviewed this PR afresh and the change still looks good to me. I'll go > ahead and sponsor this now. @jaikiran Is everything O.K. with this PR? Is it merged? Please help me. Thank you anyway. - PR Comment: https://git.openjdk.org/jdk/pull/18860#issuecomment-2080307272
Integrated: 8330686: Fix typos in the DatabaseMetaData javadoc
On Fri, 19 Apr 2024 11:33:48 GMT, Jin Kwon wrote: > Fix typos within the `DatabaseMetaData.java`. This pull request has now been integrated. Changeset: aa2edd49 Author: Jin Kwon Committer: Jaikiran Pai URL: https://git.openjdk.org/jdk/commit/aa2edd491345cca1d8798848d71b151bc06c6c02 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod 8330686: Fix typos in the DatabaseMetaData javadoc Reviewed-by: jpai, lancea, iris - PR: https://git.openjdk.org/jdk/pull/18860
Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v4]
> Fix typos within the `DatabaseMetaData.java`. Jin Kwon has updated the pull request incrementally with one additional commit since the last revision: 8330686: Fix typos in the DatabaseMetaData javadoc Reviewed-by: jpai, lancea, iris - Changes: - all: https://git.openjdk.org/jdk/pull/18860/files - new: https://git.openjdk.org/jdk/pull/18860/files/c8cf9728..94a38169 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18860&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18860&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/18860.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18860/head:pull/18860 PR: https://git.openjdk.org/jdk/pull/18860
Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v3]
> Fix typos within the `DatabaseMetaData.java`. Jin Kwon has updated the pull request incrementally with one additional commit since the last revision: 8330686: Fix typos in the DatabaseMetaData javadoc Reviewed-by: jpai - Changes: - all: https://git.openjdk.org/jdk/pull/18860/files - new: https://git.openjdk.org/jdk/pull/18860/files/75f0b111..c8cf9728 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18860&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18860&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/18860.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18860/head:pull/18860 PR: https://git.openjdk.org/jdk/pull/18860
Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc
On Sat, 20 Apr 2024 04:35:05 GMT, Jaikiran Pai wrote: >> @openjdk with issue from where? > > Hello @onacit, it appears a JBS issue has been filed for this > https://bugs.openjdk.org/browse/JDK-8330686. Please change the title of this > PR to `8330686: Fix typos in the DatabaseMetaData javadoc` so that it > triggers the official review process. @jaikiran Done. Thank you. - PR Comment: https://git.openjdk.org/jdk/pull/18860#issuecomment-2071843513
Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v2]
> Fix typos within the `DatabaseMetaData.java`. Jin Kwon has updated the pull request incrementally with one additional commit since the last revision: [JDK-8330686] Update copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/18860/files - new: https://git.openjdk.org/jdk/pull/18860/files/fbd41746..75f0b111 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18860&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18860&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18860.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18860/head:pull/18860 PR: https://git.openjdk.org/jdk/pull/18860
RFR: 8330686: Fix typos in the DatabaseMetaData javadoc
Fix typos within the `DatabaseMetaData.java`. - Commit messages: - Merge branch 'master' of github.com:onacit/jdk - Merge branch 'master' of github.com:onacit/jdk - Fix more typos - Fix typo - Fix wrongly typed constant name - Fix more typos - Fix typo - Fix wrongly typed constant name - Fix more typos - Fix typo Changes: https://git.openjdk.org/jdk/pull/18860/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18860&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330686 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/18860.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18860/head:pull/18860 PR: https://git.openjdk.org/jdk/pull/18860
Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc
On Fri, 19 Apr 2024 11:33:48 GMT, Jin Kwon wrote: > Fix typos within the `DatabaseMetaData.java`. @openjdk with issue from where? - PR Comment: https://git.openjdk.org/jdk/pull/18860#issuecomment-2066389888
