Re: RFR: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote: > File.mkdirs() occasionally fails to create folders on Windows shared folders. > It turned out that Windows API FindFirstFileW created the error > ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error > still returns this error code, which supposedly should not. > > Adding this error code into the method of lastErrorReportable in the native > code will be handled by JDK. > > To test the fix, it needs to run three Java processes to create the folders > on a remote file server. It was not backport to jdk8u. https://bugs.openjdk.org/browse/JDK-8321863 is for 8u411-perf, which is not same as jdk8u release. The bug originally was reported in jdk11, not in jdk8. That’s the reason I did not backport the change to jdk8u. From: Brian Burkhalter ***@***.***> Date: Thursday, July 18, 2024 at 2:41 PM To: openjdk/jdk ***@***.***> Cc: Weibing Xiao ***@***.***>, Mention ***@***.***> Subject: [External] : Re: [openjdk/jdk] 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder (PR #16502) Hello, Has this been backported to Java 8 ? I can't really find the info. According to the issue JDK-8321863<https://bugs.openjdk.org/browse/JDK-8321863> it looks like it has been so backported. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/openjdk/jdk/pull/16502*issuecomment-2237262955__;Iw!!ACWV5N9M2RV99hQ!PR2KjEjBmXU6E3-YKNOLy6jy2YB1Jw62HIhlGjb-fQ89qh4isQZVzbCbcjG-E9OSqjtmIyl6v3T9sPnktnn5mN-1l2w$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AP4PT5FJ7OUTZFDXWI3ZECDZNAD6JAVCNFSM6ABKW6VHHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXGI3DEOJVGU__;!!ACWV5N9M2RV99hQ!PR2KjEjBmXU6E3-YKNOLy6jy2YB1Jw62HIhlGjb-fQ89qh4isQZVzbCbcjG-E9OSqjtmIyl6v3T9sPnktnn5NbZaCuI$>. You are receiving this because you were mentioned.Message ID: ***@***.***> - PR Comment: https://git.openjdk.org/jdk/pull/16502#issuecomment-2237355311
Re: [jdk23] RFR: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14
On Wed, 10 Jul 2024 21:46:36 GMT, Justin Lu wrote: > Please review this PR, which is a backport of commit > [861aefca](https://github.com/openjdk/jdk/commit/861aefcafacdc21459ef966307f52568e327fd49) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This updates the IANA subtag registry to version 2024-06-14. The change was merged into jdk23, see the commmit https://github.com/openjdk/jdk/pull/20125 - PR Comment: https://git.openjdk.org/jdk/pull/20125#issuecomment-931615
Integrated: 8331077 : nroff man page update for jar tool
On Wed, 1 May 2024 17:52:13 GMT, Weibing Xiao wrote: > nroff man page update for jar tool. > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos This pull request has now been integrated. Changeset: c21672d8 Author: Weibing Xiao Committer: Sean Coffey URL: https://git.openjdk.org/jdk/commit/c21672d8c94da6aa613174744ceaa945ca2a474a Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod 8331077: nroff man page update for jar tool Reviewed-by: jjg, coffeys - PR: https://git.openjdk.org/jdk/pull/19039
Re: RFR: 8331077 : nroff man page update for jar tool
On Wed, 1 May 2024 17:52:13 GMT, Weibing Xiao wrote: > nroff man page update for jar tool. > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos reverted to "JDK 23-ea" - PR Comment: https://git.openjdk.org/jdk/pull/19039#issuecomment-2088901772
Re: RFR: 8331077 : nroff man page update for jar tool [v2]
> nroff man page update for jar tool. > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: version of java - Changes: - all: https://git.openjdk.org/jdk/pull/19039/files - new: https://git.openjdk.org/jdk/pull/19039/files/2808853c..b0ef5dff Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19039&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19039&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19039.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19039/head:pull/19039 PR: https://git.openjdk.org/jdk/pull/19039
RFR: 8331077 : nroff man page update for jar tool
nroff man page update for jar tool. This update is caused by the change of https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got updated in other repos, the corresponding nroff man page was never updated in OpenJDK repos - Commit messages: - 8331077 : nroff man page update for jar tool Changes: https://git.openjdk.org/jdk/pull/19039/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19039&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331077 Stats: 9 lines in 1 file changed: 4 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/19039.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19039/head:pull/19039 PR: https://git.openjdk.org/jdk/pull/19039
Withdrawn: 8331077 : nroff man page update for jar tool
On Wed, 1 May 2024 14:54:02 GMT, Weibing Xiao wrote: > nroff man page update for jar tool. > > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/19034
Re: RFR: 8331077 : nroff man page update for jar tool [v3]
On Wed, 1 May 2024 16:15:12 GMT, Weibing Xiao wrote: >> nroff man page update for jar tool. >> >> This update is caused by the change of >> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got >> updated in other repos, the corresponding nroff man page was never updated >> in OpenJDK repos > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > Revert "8331427: Rename confusingly named ArraysSupport.signedHashCode" > > This reverts commit 4f529f8c232b4082aa4aa39766bcf42b09885ee4. Close this one as I plan to use make command to update this nroff man page. - PR Comment: https://git.openjdk.org/jdk/pull/19034#issuecomment-2088703685
Re: RFR: 8331077 : nroff man page update for jar tool [v3]
> nroff man page update for jar tool. > > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: Revert "8331427: Rename confusingly named ArraysSupport.signedHashCode" This reverts commit 4f529f8c232b4082aa4aa39766bcf42b09885ee4. - Changes: - all: https://git.openjdk.org/jdk/pull/19034/files - new: https://git.openjdk.org/jdk/pull/19034/files/333dbc36..051da56e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19034&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19034&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/19034.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19034/head:pull/19034 PR: https://git.openjdk.org/jdk/pull/19034
Re: RFR: 8331077 : nroff man page update for jar tool [v2]
> nroff man page update for jar tool. > > This update is caused by the change of > https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got > updated in other repos, the corresponding nroff man page was never updated in > OpenJDK repos Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the year of copyright - Changes: - all: https://git.openjdk.org/jdk/pull/19034/files - new: https://git.openjdk.org/jdk/pull/19034/files/c78bc5dd..333dbc36 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19034&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19034&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19034.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19034/head:pull/19034 PR: https://git.openjdk.org/jdk/pull/19034
RFR: 8331077 : nroff man page update for jar tool
nroff man page update for jar tool. This update is caused by the change of https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got updated in other repos, the corresponding nroff man page was never updated in OpenJDK repos - Commit messages: - 8331077 : nroff man page update for jar tool Changes: https://git.openjdk.org/jdk/pull/19034/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19034&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331077 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/19034.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19034/head:pull/19034 PR: https://git.openjdk.org/jdk/pull/19034
[jdk22] Integrated: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
On Wed, 10 Jan 2024 17:42:21 GMT, Weibing Xiao wrote: > Better Error Handling for Jar Tool When Processing Non-existent Files. > > It needs to be backported to JDK22. This pull request has now been integrated. Changeset: 3daa936f Author: Weibing Xiao Committer: Jaikiran Pai URL: https://git.openjdk.org/jdk22/commit/3daa936f2da4da853e0cbe8dcb081e3a7509734f Stats: 86 lines in 2 files changed: 84 ins; 0 del; 2 mod 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files Reviewed-by: jpai Backport-of: 8ae309ebacd6947bbad2ef168ca13702e1cba099 - PR: https://git.openjdk.org/jdk22/pull/56
[jdk22] Withdrawn: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
On Wed, 10 Jan 2024 17:02:03 GMT, Weibing Xiao wrote: > Better Error Handling for Jar Tool When Processing Non-existent Files. > It is a clean backport. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk22/pull/55
Re: [jdk22] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
On Wed, 10 Jan 2024 17:02:03 GMT, Weibing Xiao wrote: > Better Error Handling for Jar Tool When Processing Non-existent Files. > It is a clean backport. Use this PR instead https://github.com/openjdk/jdk22/pull/56. - PR Comment: https://git.openjdk.org/jdk22/pull/55#issuecomment-1885333004
[jdk22] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
Better Error Handling for Jar Tool When Processing Non-existent Files. It needs to be backported to JDK22. - Commit messages: - Backport 8ae309ebacd6947bbad2ef168ca13702e1cba099 Changes: https://git.openjdk.org/jdk22/pull/56/files Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=56&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318971 Stats: 86 lines in 2 files changed: 84 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22/pull/56.diff Fetch: git fetch https://git.openjdk.org/jdk22.git pull/56/head:pull/56 PR: https://git.openjdk.org/jdk22/pull/56
[jdk22] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
Better Error Handling for Jar Tool When Processing Non-existent Files. It is a clean backport. - Commit messages: - Backport 8ae309ebacd6947bbad2ef168ca13702e1cba099 Changes: https://git.openjdk.org/jdk22/pull/55/files Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=55&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318971 Stats: 86 lines in 2 files changed: 84 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22/pull/55.diff Fetch: git fetch https://git.openjdk.org/jdk22.git pull/55/head:pull/55 PR: https://git.openjdk.org/jdk22/pull/55
Integrated: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files
On Wed, 13 Dec 2023 18:16:56 GMT, Weibing Xiao wrote: > Better Error Handling for Jar Tool Processing of "@File" > > This is a new PR for this PR since the original developer left the team. See > all of the review history at https://github.com/openjdk/jdk/pull/16423. > > Thank you. This pull request has now been integrated. Changeset: 8ae309eb Author:Weibing Xiao Committer: Jaikiran Pai URL: https://git.openjdk.org/jdk/commit/8ae309ebacd6947bbad2ef168ca13702e1cba099 Stats: 86 lines in 2 files changed: 84 ins; 0 del; 2 mod 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files Reviewed-by: alanb, jpai - PR: https://git.openjdk.org/jdk/pull/17088
Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v4]
> Better Error Handling for Jar Tool Processing of "@File" > > This is a new PR for this PR since the original developer left the team. See > all of the review history at https://github.com/openjdk/jdk/pull/16423. > > Thank you. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the test cases - Changes: - all: https://git.openjdk.org/jdk/pull/17088/files - new: https://git.openjdk.org/jdk/pull/17088/files/ba9335e0..ff349833 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17088&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17088&range=02-03 Stats: 39 lines in 1 file changed: 35 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/17088.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17088/head:pull/17088 PR: https://git.openjdk.org/jdk/pull/17088
Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v2]
On Tue, 19 Dec 2023 17:24:15 GMT, Weibing Xiao wrote: >> Better Error Handling for Jar Tool Processing of "@File" >> >> This is a new PR for this PR since the original developer left the team. See >> all of the review history at https://github.com/openjdk/jdk/pull/16423. >> >> Thank you. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > remove one test case and add the comments 1) the man page update will be in another PR 2) Update the title of JBS bug and put the description in. Literarily I copied Jai's comments 3) Removed test case of testMultipleFilesInClassesList, I don't believe it is related to the change 4) Added the comments for two other test cases and updated the test. - PR Comment: https://git.openjdk.org/jdk/pull/17088#issuecomment-1863499364
Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v3]
> Better Error Handling for Jar Tool Processing of "@File" > > This is a new PR for this PR since the original developer left the team. See > all of the review history at https://github.com/openjdk/jdk/pull/16423. > > Thank you. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: updat testing cases - Changes: - all: https://git.openjdk.org/jdk/pull/17088/files - new: https://git.openjdk.org/jdk/pull/17088/files/62a52f5a..ba9335e0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17088&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17088&range=01-02 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/17088.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17088/head:pull/17088 PR: https://git.openjdk.org/jdk/pull/17088
Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v2]
> Better Error Handling for Jar Tool Processing of "@File" > > This is a new PR for this PR since the original developer left the team. See > all of the review history at https://github.com/openjdk/jdk/pull/16423. > > Thank you. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: remove one test case and add the comments - Changes: - all: https://git.openjdk.org/jdk/pull/17088/files - new: https://git.openjdk.org/jdk/pull/17088/files/b944aac8..62a52f5a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17088&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17088&range=00-01 Stats: 27 lines in 1 file changed: 10 ins; 17 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/17088.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17088/head:pull/17088 PR: https://git.openjdk.org/jdk/pull/17088
RFR: 8318971 : Better Error Handling for Jar Tool Processing of @File
Better Error Handling for Jar Tool Processing of "@File" This is a new PR for this PR since the original developer left the team. See all of the review history at https://github.com/openjdk/jdk/pull/16423. Thank you. - Commit messages: - 8318971 : Better Error Handling for Jar Tool Processing of @File Changes: https://git.openjdk.org/jdk/pull/17088/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17088&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318971 Stats: 56 lines in 2 files changed: 54 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/17088.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17088/head:pull/17088 PR: https://git.openjdk.org/jdk/pull/17088
Integrated: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote: > File.mkdirs() occasionally fails to create folders on Windows shared folders. > It turned out that Windows API FindFirstFileW created the error > ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error > still returns this error code, which supposedly should not. > > Adding this error code into the method of lastErrorReportable in the native > code will be handled by JDK. > > To test the fix, it needs to run three Java processes to create the folders > on a remote file server. This pull request has now been integrated. Changeset: 7ad70059 Author:Weibing Xiao Committer: Brian Burkhalter URL: https://git.openjdk.org/jdk/commit/7ad700596fbc58c27fedfa46755e80ea57712fac Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8315034: File.mkdirs() occasionally fails to create folders on Windows shared folder Reviewed-by: bpb - PR: https://git.openjdk.org/jdk/pull/16502
Re: RFR: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote: > File.mkdirs() occasionally fails to create folders on Windows shared folders. > It turned out that Windows API FindFirstFileW created the error > ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error > still returns this error code, which supposedly should not. > > Adding this error code into the method of lastErrorReportable in the native > code will be handled by JDK. > > To test the fix, it needs to run three Java processes to create the folders > on a remote file server. Removed the test file and added the label to JBS - PR Comment: https://git.openjdk.org/jdk/pull/16502#issuecomment-1833862715
RFR: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder
File.mkdirs() occasionally fails to create folders on Windows shared folders. It turned out that Windows API FindFirstFileW created the error ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error still returns this error code, which supposedly should not. Adding this error code into the method of lastErrorReportable in the native code will be handled by JDK. To test the fix, it needs to run three Java processes to create the folders on a remote file server. - Commit messages: - remove test file - 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder Changes: https://git.openjdk.org/jdk/pull/16502/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16502&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315034 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/16502.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16502/head:pull/16502 PR: https://git.openjdk.org/jdk/pull/16502
Re: RFR: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder
On Mon, 6 Nov 2023 20:19:25 GMT, Brian Burkhalter wrote:
>> src/java.base/windows/native/libjava/canonicalize_md.c line 142:
>>
>>> 140: || (errval == ERROR_NETWORK_UNREACHABLE)
>>> 141: || (errval == ERROR_NETWORK_ACCESS_DENIED)
>>> 142: || (errval == ERROR_NO_MORE_FILES)) {
>>
>> @bplb Is this the same thing as JDK-8234363? Does this also need to be
>> handled in the FindFirstFile usage in WindowsDirectoryStream?
>
> It seems likely. I don't recall having been able to replicate these problems
> however.
I used to duplicate it quite easily on my personal laptop with JDK11 (one
laptop with Windows 11, the other with Windows 10). After my laptop system got
updated, it was almost impossible to recreate it with my two laptops. To verify
this bug, we have to configure exactly the same testing environment as the
customer was having.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16502#discussion_r1387151896
Integrated: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
On Tue, 15 Aug 2023 17:30:54 GMT, Weibing Xiao wrote: > Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. This pull request has now been integrated. Changeset: f2383b3c Author:Weibing Xiao Committer: Aleksei Efimov URL: https://git.openjdk.org/jdk/commit/f2383b3cbd1096f0b38e89a3d876da2217511f11 Stats: 357 lines in 3 files changed: 290 ins; 42 del; 25 mod 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection Reviewed-by: aefimov, msheppar - PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v14]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/71bca08c..f03bb797 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=13 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=12-13 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v13]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: format the code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/be3bd44f..71bca08c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=12 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=11-12 Stats: 94 lines in 1 file changed: 1 ins; 1 del; 92 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v12]
On Thu, 24 Aug 2023 18:45:01 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > update the code according to code review 1) Add server sleeping time through the command line 2) Move out instanceof pattern out of the defined method 3)Extra testings were done. - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1692301763
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v12]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the code according to code review - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/cdb70069..be3bd44f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=11 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=10-11 Stats: 106 lines in 2 files changed: 30 ins; 22 del; 54 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v10]
On Tue, 22 Aug 2023 18:21:17 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > format the code Please see the updated code. Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1690796916
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v11]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: refactoring the code according to the comment - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/2e0e80fa..cdb70069 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=10 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=09-10 Stats: 205 lines in 1 file changed: 33 ins; 52 del; 120 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v10]
On Tue, 22 Aug 2023 18:21:17 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > format the code If the custom factory does not implement the method creatSocket (no method parameters), it will fail for creating the socket. The SocketFactory::createSocket is not defined as an abstract method, instead, it throws UnsupportedOperationException. The subclass is not required to implement it. - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1689033617
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v10]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: format the code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/212ee7fa..2e0e80fa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=09 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=08-09 Stats: 22 lines in 1 file changed: 10 ins; 10 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v9]
On Mon, 21 Aug 2023 22:10:06 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > use original logic to create socket to avoid the compatibility issue Formatted the code according to the comments. - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1688652418
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v9]
On Mon, 21 Aug 2023 22:10:06 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > use original logic to create socket to avoid the compatibility issue Brought back the original logic. The modified logic created the compatibility issue. Please check the change again. Thank you. - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1687137973
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v9]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: use original logic to create socket to avoid the compatibility issue - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/8c23a747..212ee7fa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=07-08 Stats: 43 lines in 1 file changed: 24 ins; 0 del; 19 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v7]
On Sat, 19 Aug 2023 02:15:06 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > refactor the code and test cases 1) Reformat the test code 2) Add one more comment in Connection.java 3) Updated the test code base on the review comment - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1686489715
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v8]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the code based on the review - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/e9e0497f..8c23a747 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=06-07 Stats: 70 lines in 2 files changed: 22 ins; 23 del; 25 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v6]
On Fri, 18 Aug 2023 13:30:54 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > re-write close method 1) Refactor the code again, and simplify the code to handle the setting of connection time 2) Add more test cases 3) Bring back the pre-created keystore. I could not find a good example to create the key store at runtime. - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1684688234
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v7]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: refactor the code and test cases - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/ac72c3d8..e9e0497f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=05-06 Stats: 121 lines in 3 files changed: 48 ins; 36 del; 37 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v5]
On Fri, 18 Aug 2023 13:20:50 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > update the Connection code 1) Please ignore the previous change for Connection.java 2) Refactor the method of createSocket 3) Re-write closedOpenedSocket, and remove closeSocket method. - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1683918936
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v6]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: re-write close method - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/3df1b6cc..ac72c3d8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=04-05 Stats: 18 lines in 1 file changed: 1 ins; 13 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v5]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the Connection code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/e4898a54..3df1b6cc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=03-04 Stats: 58 lines in 1 file changed: 21 ins; 11 del; 26 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v4]
On Thu, 17 Aug 2023 21:20:04 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > refactor the code and remove pre-created keystore 1) Refactor the code according to the suggestion 2) Removed the pre-created key store and re-create it at the runtime. - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1682997687
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v4]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: refactor the code and remove pre-created keystore - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/0cae2343..e4898a54 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=02-03 Stats: 131 lines in 3 files changed: 46 ins; 54 del; 31 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v2]
On Wed, 16 Aug 2023 22:49:24 GMT, Mark Sheppard wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the test code
>
> test/jdk/com/sun/jndi/ldap/LdapSSLHandshakeFailureTest.java line 173:
>
>> 171: public void run() {
>> 172: try (Socket socket = serverSocket.accept()) {
>> 173: Thread.sleep(1);
>
> What's the purpose of the sleep ?
> Regardless, based on the test semantics alluded in the test name, the server
> should never enter the read block. So is this code redundant? Or is it there
> just in case the accept and the handshake succeeds?
It will slow down the handshake process after the socket is created and
connected with the server. The bug is showing the handshake failure and the
socket is not closed properly.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/15294#discussion_r1296522377
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v3]
On Wed, 16 Aug 2023 23:11:11 GMT, Weibing Xiao wrote: >> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > updated the code according to the review 1) Refactor Connection::createSocket 2) Update the test code. - PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1681383275
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v3]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: updated the code according to the review - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/5e83e6ff..0cae2343 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=01-02 Stats: 195 lines in 2 files changed: 83 ins; 62 del; 50 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Re: RFR: 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection [v2]
> Please refer to JDK-8314063. > > The failure scenario is due to the setting of connection timeout. It is > either too small or not an optimal value for the system. When the client > tries to connect to the server with LDAPs protocol. It requires the handshake > after the socket is created and connected, but it fails due to connection > timeout and leaves the socket open. It is not closed properly due to the > exception handling in the JDK code. > > The change is adding a try/catch block and closing the socket in the catch > block, and the format of the code got changed consequently. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update the test code - Changes: - all: https://git.openjdk.org/jdk/pull/15294/files - new: https://git.openjdk.org/jdk/pull/15294/files/e5d981ea..5e83e6ff Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
RFR: 8314063 : The socket is not closed in Connection::createSocket when t…
Please refer to JDK-8314063. The failure scenario is due to the setting of connection timeout. It is either too small or not an optimal value for the system. When the client tries to connect to the server with LDAPs protocol. It requires the handshake after the socket is created and connected, but it fails due to connection timeout and leaves the socket open. It is not closed properly due to the exception handling in the JDK code. The change is adding a try/catch block and closing the socket in the catch block, and the format of the code got changed consequently. - Commit messages: - remove the unused import - 8314063 : The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection Changes: https://git.openjdk.org/jdk/pull/15294/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15294&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314063 Stats: 286 lines in 3 files changed: 229 ins; 15 del; 42 mod Patch: https://git.openjdk.org/jdk/pull/15294.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15294/head:pull/15294 PR: https://git.openjdk.org/jdk/pull/15294
Integrated: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
On Thu, 3 Aug 2023 17:32:43 GMT, Weibing Xiao wrote: > com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. This pull request has now been integrated. Changeset: e56d3bc2 Author: Weibing Xiao Committer: Aleksei Efimov URL: https://git.openjdk.org/jdk/commit/e56d3bc2dab3d32453b6eda66e8434953c436084 Stats: 214 lines in 2 files changed: 205 ins; 2 del; 7 mod 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors Reviewed-by: vtewari, msheppar, aefimov - PR: https://git.openjdk.org/jdk/pull/15143
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v5]
On Wed, 9 Aug 2023 12:52:35 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > class access modifier Updated LdapInputStream.java and remove the unused variable. - PR Comment: https://git.openjdk.org/jdk/pull/15143#issuecomment-1677275894
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v6]
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: removed the unused variable - Changes: - all: https://git.openjdk.org/jdk/pull/15143/files - new: https://git.openjdk.org/jdk/pull/15143/files/e3e98226..b7d0c257 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=04-05 Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/15143.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15143/head:pull/15143 PR: https://git.openjdk.org/jdk/pull/15143
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v4]
On Wed, 9 Aug 2023 00:21:55 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > update method name and test case 1) Cannot make CustomSocket be private. The test failed. I believe JDK is using the reflection to load the class. 2) The rest of the changes are based on the comments. - PR Comment: https://git.openjdk.org/jdk/pull/15143#issuecomment-1671228915
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v5]
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: class access modifier - Changes: - all: https://git.openjdk.org/jdk/pull/15143/files - new: https://git.openjdk.org/jdk/pull/15143/files/b46537be..e3e98226 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=03-04 Stats: 6 lines in 1 file changed: 0 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/15143.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15143/head:pull/15143 PR: https://git.openjdk.org/jdk/pull/15143
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v3]
On Fri, 4 Aug 2023 19:09:58 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > update error message 1) Update the name of the methods 2) Update the test file. - PR Comment: https://git.openjdk.org/jdk/pull/15143#issuecomment-1670475452
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v4]
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update method name and test case - Changes: - all: https://git.openjdk.org/jdk/pull/15143/files - new: https://git.openjdk.org/jdk/pull/15143/files/f33a565c..b46537be Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=02-03 Stats: 16 lines in 2 files changed: 7 ins; 5 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/15143.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15143/head:pull/15143 PR: https://git.openjdk.org/jdk/pull/15143
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v3]
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update error message - Changes: - all: https://git.openjdk.org/jdk/pull/15143/files - new: https://git.openjdk.org/jdk/pull/15143/files/abf8126c..f33a565c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=01-02 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/15143.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15143/head:pull/15143 PR: https://git.openjdk.org/jdk/pull/15143
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v2]
On Fri, 4 Aug 2023 18:24:04 GMT, Weibing Xiao wrote: >> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if >> the is an IOException generation when the output stream was flushing the >> buffer. >> >> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > updated the code according the review comments 1) Extracted the methods for finally black of Connection::cleanUP 2) Move the test class to LDAP test folder and updated the test comments. 3) Removed the redundant code and update the import statement. - PR Comment: https://git.openjdk.org/jdk/pull/15143#issuecomment-1666054865
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v2]
> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if > the is an IOException generation when the output stream was flushing the > buffer. > > Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: updated the code according the review comments - Changes: - all: https://git.openjdk.org/jdk/pull/15143/files - new: https://git.openjdk.org/jdk/pull/15143/files/c7feb93f..abf8126c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=00-01 Stats: 409 lines in 3 files changed: 205 ins; 198 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/15143.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15143/head:pull/15143 PR: https://git.openjdk.org/jdk/pull/15143
Re: RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
On Thu, 3 Aug 2023 17:59:10 GMT, Alan Bateman wrote:
>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if
>> the is an IOException generation when the output stream was flushing the
>> buffer.
>>
>> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.
>
> src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line 658:
>
>> 656: unpauseReader();
>> 657: if (debug) {
>> 658: if (sock.isClosed()) {
>
> How is it possible for sock.close() to succeed but isClosed to return false?
It is an unreachable code and got removed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/15143#discussion_r1283640395
RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if the is an IOException generation when the output stream was flushing the buffer. Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657. - Commit messages: - reformat the code - remove unreachable code and reformatting the code - 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors Changes: https://git.openjdk.org/jdk/pull/15143/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15143&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313657 Stats: 197 lines in 2 files changed: 196 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/15143.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15143/head:pull/15143 PR: https://git.openjdk.org/jdk/pull/15143
Integrated: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64
On Mon, 28 Nov 2022 16:52:09 GMT, Weibing Xiao wrote: > fix the illegal characters of directory names in Windows This pull request has now been integrated. Changeset: cdf9ed07 Author: Weibing Xiao Committer: Roger Riggs URL: https://git.openjdk.org/jdk/commit/cdf9ed07de102ae388278163e3bf702d861fc30a Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64 Reviewed-by: rriggs, iris, bpb, naoto - PR: https://git.openjdk.org/jdk/pull/11393
RFR: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64
fix the illegal characters of directory names in Windows - Commit messages: - fix illegal charater of directory name in Windows Changes: https://git.openjdk.org/jdk/pull/11393/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11393&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297528 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11393.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11393/head:pull/11393 PR: https://git.openjdk.org/jdk/pull/11393
Integrated: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
On Tue, 15 Nov 2022 19:02:30 GMT, Weibing Xiao wrote: > print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. This pull request has now been integrated. Changeset: 8df3bc4e Author:Weibing Xiao Committer: Sean Coffey URL: https://git.openjdk.org/jdk/commit/8df3bc4ec57a15d5bca844e030c8cc3f8c077a49 Stats: 140 lines in 4 files changed: 136 ins; 0 del; 4 mod 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist Reviewed-by: rriggs, naoto, coffeys - PR: https://git.openjdk.org/jdk/pull/11174
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v5]
> print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update according to the review comments - Changes: - all: https://git.openjdk.org/jdk/pull/11174/files - new: https://git.openjdk.org/jdk/pull/11174/files/38f8855b..ba12fc0b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11174&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11174&range=03-04 Stats: 8 lines in 3 files changed: 1 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/11174.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11174/head:pull/11174 PR: https://git.openjdk.org/jdk/pull/11174
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]
> print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: updated from the review comment - Changes: - all: https://git.openjdk.org/jdk/pull/11174/files - new: https://git.openjdk.org/jdk/pull/11174/files/ede6c42e..38f8855b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11174&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11174&range=02-03 Stats: 249 lines in 3 files changed: 119 ins; 130 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/11174.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11174/head:pull/11174 PR: https://git.openjdk.org/jdk/pull/11174
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v3]
> print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: update according to review comment - Changes: - all: https://git.openjdk.org/jdk/pull/11174/files - new: https://git.openjdk.org/jdk/pull/11174/files/bcbba19e..ede6c42e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11174&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11174&range=01-02 Stats: 52 lines in 3 files changed: 17 ins; 14 del; 21 mod Patch: https://git.openjdk.org/jdk/pull/11174.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11174/head:pull/11174 PR: https://git.openjdk.org/jdk/pull/11174
Withdrawn: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
On Tue, 23 Aug 2022 18:32:30 GMT, Weibing Xiao wrote: > 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/9989
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 11 commits: > > - Merge branch 'master' into improve-directory-not-existing-error-message > - new approach: print warning in StaticProperty.java > - Merge branch 'master' into improve-directory-not-existing-error-message > - add the change for nio and update the code according to the comments > - new approach > - change based on the review > - updating according to the comments > - Merge branch 'master' of https://github.com/openjdk/jdk into > improve-directory-not-existing-error-message > - update error message > - error message for non-existing directory > - ... and 1 more: https://git.openjdk.org/jdk/compare/8487c56f...2da71bdc Close this one, Using https://github.com/openjdk/jdk/pull/11174 instead - PR: https://git.openjdk.org/jdk/pull/9989
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
On Tue, 15 Nov 2022 19:02:30 GMT, Weibing Xiao wrote: > print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. 1) Removed the link for CSR. 2) Add a new method in SystemProps.java to check if the warning message is required 3) Print the warning message directly in System::initPhase3 - PR: https://git.openjdk.org/jdk/pull/11174
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v2]
> print warning message for java.io.tmpdir when it is set through the command > line and the value is not good for creating file folder. Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: the change according to review comment - Changes: - all: https://git.openjdk.org/jdk/pull/11174/files - new: https://git.openjdk.org/jdk/pull/11174/files/0449a6d9..bcbba19e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11174&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11174&range=00-01 Stats: 13 lines in 2 files changed: 4 ins; 1 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/11174.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11174/head:pull/11174 PR: https://git.openjdk.org/jdk/pull/11174
RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
print warning message for java.io.tmpdir when it is set through the command line and the value is not good for creating file folder. - Commit messages: - remove extra line - warning message for java.io.tmpdir Changes: https://git.openjdk.org/jdk/pull/11174/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11174&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290313 Stats: 146 lines in 4 files changed: 142 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/11174.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11174/head:pull/11174 PR: https://git.openjdk.org/jdk/pull/11174
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 11 commits: > > - Merge branch 'master' into improve-directory-not-existing-error-message > - new approach: print warning in StaticProperty.java > - Merge branch 'master' into improve-directory-not-existing-error-message > - add the change for nio and update the code according to the comments > - new approach > - change based on the review > - updating according to the comments > - Merge branch 'master' of https://github.com/openjdk/jdk into > improve-directory-not-existing-error-message > - update error message > - error message for non-existing directory > - ... and 1 more: https://git.openjdk.org/jdk/compare/8487c56f...2da71bdc StaticProperty is using System.err to print out a warning message. PrintStream err needs to be initialized before being used by StaticPropery. Going to revise the change according to the comments - PR: https://git.openjdk.org/jdk/pull/9989
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 11 commits: > > - Merge branch 'master' into improve-directory-not-existing-error-message > - new approach: print warning in StaticProperty.java > - Merge branch 'master' into improve-directory-not-existing-error-message > - add the change for nio and update the code according to the comments > - new approach > - change based on the review > - updating according to the comments > - Merge branch 'master' of https://github.com/openjdk/jdk into > improve-directory-not-existing-error-message > - update error message > - error message for non-existing directory > - ... and 1 more: https://git.openjdk.org/jdk/compare/8487c56f...2da71bdc New approach, 1) Print warning message inside StaticProperty.java when JVM start 2) Remove the print-out inside TempFileHelper.java and File.java 3) Keep one test file as TempDirectoryNotExisting 4) The order of the code was changed in System.java since StaticProperty.java needs "out print-stream" to be initialized before using it to print a warning message. - PR: https://git.openjdk.org/jdk/pull/9989
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist Weibing Xiao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'master' into improve-directory-not-existing-error-message - new approach: print warning in StaticProperty.java - Merge branch 'master' into improve-directory-not-existing-error-message - add the change for nio and update the code according to the comments - new approach - change based on the review - updating according to the comments - Merge branch 'master' of https://github.com/openjdk/jdk into improve-directory-not-existing-error-message - update error message - error message for non-existing directory - ... and 1 more: https://git.openjdk.org/jdk/compare/8487c56f...2da71bdc - Changes: https://git.openjdk.org/jdk/pull/9989/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9989&range=03 Stats: 160 lines in 7 files changed: 147 ins; 2 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/9989.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9989/head:pull/9989 PR: https://git.openjdk.org/jdk/pull/9989
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v3]
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist Weibing Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - new approach: print warning in StaticProperty.java - Merge branch 'master' into improve-directory-not-existing-error-message - add the change for nio and update the code according to the comments - new approach - change based on the review - updating according to the comments - Merge branch 'master' of https://github.com/openjdk/jdk into improve-directory-not-existing-error-message - update error message - error message for non-existing directory - improve error message when file directory does not exist - Changes: - all: https://git.openjdk.org/jdk/pull/9989/files - new: https://git.openjdk.org/jdk/pull/9989/files/cacf41d6..abb19138 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9989&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9989&range=01-02 Stats: 92095 lines in 1709 files changed: 45132 ins; 36514 del; 10449 mod Patch: https://git.openjdk.org/jdk/pull/9989.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9989/head:pull/9989 PR: https://git.openjdk.org/jdk/pull/9989
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
On Tue, 23 Aug 2022 18:32:30 GMT, Weibing Xiao wrote: > 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist 1) Remove the setting in java.security, not displaying the folder name of java.io.tmpdir 2) Add the change for NIO 3) Update the testing files. 4) In testing files, java.io.tmpdir is added as the option of command line - PR: https://git.openjdk.org/jdk/pull/9989
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v2]
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision: add the change for nio and update the code according to the comments - Changes: - all: https://git.openjdk.org/jdk/pull/9989/files - new: https://git.openjdk.org/jdk/pull/9989/files/9f5a2983..cacf41d6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9989&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9989&range=00-01 Stats: 90 lines in 6 files changed: 69 ins; 12 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/9989.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9989/head:pull/9989 PR: https://git.openjdk.org/jdk/pull/9989
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
On Wed, 24 Aug 2022 04:42:54 GMT, David Schlosnagle wrote:
>> 8290313: Produce warning when user specified java.io.tmpdir directory
>> doesn't exist
>
> src/java.base/share/classes/java/io/File.java line 2180:
>
>> 2178:
>> 2179:
>> 2180: if(!tmpdir.exists() || !tmpdir.canWrite()) {
>
> Should this check that `tmpdir.isDirectory()` that will do both existence &
> directory check? That would catch if java.io.t odor was mistakenly set to an
> existing (writable) file.
>
> Suggestion:
>
> if(!tmpdir.isDirectory() || !tmpdir.canWrite()) {
Using a new approach, please check the new commits. Thanks.
-
PR: https://git.openjdk.org/jdk/pull/9989
Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
On Tue, 23 Aug 2022 18:32:30 GMT, Weibing Xiao wrote: > 8290313: Produce warning when user specified java.io.tmpdir directory doesn't > exist CSR https://bugs.openjdk.org/browse/JDK-8293246 - PR: https://git.openjdk.org/jdk/pull/9989
RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist - Commit messages: - new approach - change based on the review - updating according to the comments - Merge branch 'master' of https://github.com/openjdk/jdk into improve-directory-not-existing-error-message - update error message - error message for non-existing directory - improve error message when file directory does not exist Changes: https://git.openjdk.org/jdk/pull/9989/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9989&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290313 Stats: 82 lines in 3 files changed: 79 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/9989.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9989/head:pull/9989 PR: https://git.openjdk.org/jdk/pull/9989
