Integrated: 8331851: Add specific regression leap year tests for Calendar.roll()
On Wed, 15 May 2024 09:39:16 GMT, serhiysachkov wrote: > Add specific regression tests for Calendar.roll() method to explicitly > various leap year test scenarios. This is inspired by the ambiguity which > occurred in leap year unaware test creation as in case with Calendar.add() in > swing component test case as detailed in > (https://bugs.openjdk.org/browse/JDK-8327088). This pull request has now been integrated. Changeset: d6b7f9b1 Author:Serhiy Sachkov Committer: Mahendra Chhipa URL: https://git.openjdk.org/jdk/commit/d6b7f9b170b6ce4f7275cc7595b71b9a3e93c133 Stats: 190 lines in 1 file changed: 190 ins; 0 del; 0 mod 8331851: Add specific regression leap year tests for Calendar.roll() Reviewed-by: naoto - PR: https://git.openjdk.org/jdk/pull/19247
RFR: 8331851: Add specific regression leap year tests for Calendar.roll()
Add specific regression tests for Calendar.roll() method to explicitly various leap year test scenarios. This is inspired by the ambiguity which occurred in leap year unaware test creation as in case with Calendar.add() in swing component test case as detailed in (https://bugs.openjdk.org/browse/JDK-8327088). - Commit messages: - JDK-8331851 Add specific regression leap year tests for Calendar.roll() Changes: https://git.openjdk.org/jdk/pull/19247/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19247=00 Issue: https://bugs.openjdk.org/browse/JDK-8331851 Stats: 190 lines in 1 file changed: 190 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19247.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19247/head:pull/19247 PR: https://git.openjdk.org/jdk/pull/19247
Integrated: 8331646: Add specific regression leap year tests
On Fri, 3 May 2024 10:31:14 GMT, serhiysachkov wrote: > Calendar.add() tests that describe its behavior. This pull request has now been integrated. Changeset: d11e70ad Author:Serhiy Sachkov Committer: Mahendra Chhipa URL: https://git.openjdk.org/jdk/commit/d11e70ade3e9094c8bef0074c736215d48d47a2a Stats: 129 lines in 1 file changed: 129 ins; 0 del; 0 mod 8331646: Add specific regression leap year tests Reviewed-by: naoto - PR: https://git.openjdk.org/jdk/pull/19082
Re: RFR: 8331646: Add specific regression leap year tests [v5]
> Calendar.add() tests that describe its behavior. serhiysachkov has updated the pull request incrementally with one additional commit since the last revision: JDK-8331646 fixing typo - Changes: - all: https://git.openjdk.org/jdk/pull/19082/files - new: https://git.openjdk.org/jdk/pull/19082/files/f6ba2e31..8e070b4e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19082=04 - incr: https://webrevs.openjdk.org/?repo=jdk=19082=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19082.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19082/head:pull/19082 PR: https://git.openjdk.org/jdk/pull/19082
Re: RFR: 8331646: Add specific regression leap year tests [v4]
> Calendar.add() tests that describe its behavior. serhiysachkov has updated the pull request incrementally with one additional commit since the last revision: JDK-8331646 updating impl according to review requests - Changes: - all: https://git.openjdk.org/jdk/pull/19082/files - new: https://git.openjdk.org/jdk/pull/19082/files/4bb425da..f6ba2e31 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19082=03 - incr: https://webrevs.openjdk.org/?repo=jdk=19082=02-03 Stats: 32 lines in 1 file changed: 11 ins; 3 del; 18 mod Patch: https://git.openjdk.org/jdk/pull/19082.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19082/head:pull/19082 PR: https://git.openjdk.org/jdk/pull/19082
Re: RFR: JDK-8331646: Add specific regression leap year tests (Task - P4) [v2]
On Tue, 7 May 2024 16:43:11 GMT, Naoto Sato wrote: > Sorry if I was unclear, but I meant to consolidate the test methods, as they > are duplicates other than the calendar values. Those values should be > parametrized and consolidate the test body into a single method. sorry for misunderstanding, I was trying to provide scenarios that are easy to follow and understand for devs, but you are right we don't need duplication there. - PR Comment: https://git.openjdk.org/jdk/pull/19082#issuecomment-2100383313
Re: RFR: JDK-8331646: Add specific regression leap year tests (Task - P4) [v3]
> Calendar.add() tests that describe its behavior. serhiysachkov has updated the pull request incrementally with one additional commit since the last revision: JDK-8331646 consolidating test methods into ParameterizedTests - Changes: - all: https://git.openjdk.org/jdk/pull/19082/files - new: https://git.openjdk.org/jdk/pull/19082/files/bce324f3..4bb425da Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19082=02 - incr: https://webrevs.openjdk.org/?repo=jdk=19082=01-02 Stats: 234 lines in 1 file changed: 6 ins; 178 del; 50 mod Patch: https://git.openjdk.org/jdk/pull/19082.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19082/head:pull/19082 PR: https://git.openjdk.org/jdk/pull/19082
Re: RFR: JDK-8331646: Add specific regression leap year tests (Task - P4) [v2]
> Calendar.add() tests that describe its behavior. serhiysachkov has updated the pull request incrementally with one additional commit since the last revision: JDK-8331646 updating to ParameterizedTests according to review request - Changes: - all: https://git.openjdk.org/jdk/pull/19082/files - new: https://git.openjdk.org/jdk/pull/19082/files/3d09d62c..bce324f3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19082=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19082=00-01 Stats: 79 lines in 1 file changed: 23 ins; 0 del; 56 mod Patch: https://git.openjdk.org/jdk/pull/19082.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19082/head:pull/19082 PR: https://git.openjdk.org/jdk/pull/19082
Re: RFR: JDK-8331646: Add specific regression leap year tests (Task - P4)
On Fri, 3 May 2024 10:31:14 GMT, serhiysachkov wrote: > Calendar.add() tests that describe its behavior. This PR provides additional tests that clarify behavior of Calendar.add() method for leap year, specifically behavior that led to this ticket https://bugs.openjdk.org/browse/JDK-8327088. - PR Comment: https://git.openjdk.org/jdk/pull/19082#issuecomment-2097814095
RFR: JDK-8331646: Add specific regression leap year tests (Task - P4)
Calendar.add() tests that describe its behavior. - Commit messages: - Merge remote-tracking branch 'origin/JDK-8331646' into JDK-8331646 - JDK-8331646 adding tests to validate Calendar.add() for leap year - JDK-8331646 Add specific regression leap year tests Changes: https://git.openjdk.org/jdk/pull/19082/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19082=00 Issue: https://bugs.openjdk.org/browse/JDK-8331646 Stats: 270 lines in 1 file changed: 270 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19082.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19082/head:pull/19082 PR: https://git.openjdk.org/jdk/pull/19082
