Re: [jdk19] RFR: 8289779: Map::replaceAll javadoc has redundant @throws clauses [v2]
> Simple javadoc fix of an editorial nature. Stuart Marks has updated the pull request incrementally with one additional commit since the last revision: Reflow and adjust whitespace per Alan's & Iris' comments. - Changes: - all: https://git.openjdk.org/jdk19/pull/111/files - new: https://git.openjdk.org/jdk19/pull/111/files/8902f466..a3fbdb5b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk19=111=01 - incr: https://webrevs.openjdk.org/?repo=jdk19=111=00-01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk19/pull/111.diff Fetch: git fetch https://git.openjdk.org/jdk19 pull/111/head:pull/111 PR: https://git.openjdk.org/jdk19/pull/111
Re: [jdk19] RFR: 8289779: Map::replaceAll javadoc has redundant @throws clauses
On Wed, 6 Jul 2022 00:32:00 GMT, Stuart Marks wrote:
> Simple javadoc fix of an editorial nature.
src/java.base/share/classes/java/util/Map.java line 745:
> 743: * ( href="{@docRoot}/java.base/java/util/Collection.html#optional-restrictions">optional)
> 744: * @throws NullPointerException if the specified function is null,
> or if a replacement value is null
> 745: * and this map does not permit null values
This looks okay although I'd probably reflow L744-745 to avoid to keep the line
lengths somewhat consistent with the other exceptions.
-
PR: https://git.openjdk.org/jdk19/pull/111
Re: [jdk19] RFR: 8289779: Map::replaceAll javadoc has redundant @throws clauses [v2]
On Wed, 6 Jul 2022 23:03:42 GMT, Stuart Marks wrote: >> Simple javadoc fix of an editorial nature. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Reflow and adjust whitespace per Alan's & Iris' comments. Marked as reviewed by prappo (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/111
Re: [jdk19] RFR: 8289779: Map::replaceAll javadoc has redundant @throws clauses [v2]
On Wed, 6 Jul 2022 23:03:42 GMT, Stuart Marks wrote: >> Simple javadoc fix of an editorial nature. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Reflow and adjust whitespace per Alan's & Iris' comments. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/111
Re: [jdk19] RFR: 8289779: Map::replaceAll javadoc has redundant @throws clauses
On Wed, 6 Jul 2022 00:32:00 GMT, Stuart Marks wrote:
> Simple javadoc fix of an editorial nature.
Marked as reviewed by iris (Reviewer).
src/java.base/share/classes/java/util/Map.java line 740:
> 738: * @param function the function to apply to each entry
> 739: * @throws UnsupportedOperationException if the {@code set} operation
> 740: * is not supported by this map's entry set iterator.
Maybe fix indentation here and at line 742 for the CCE for consistency?
-
PR: https://git.openjdk.org/jdk19/pull/111
Re: [jdk19] RFR: 8289779: Map::replaceAll javadoc has redundant @throws clauses [v2]
On Wed, 6 Jul 2022 23:03:42 GMT, Stuart Marks wrote: >> Simple javadoc fix of an editorial nature. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Reflow and adjust whitespace per Alan's & Iris' comments. Reflowed and adjusted whitespace. Also, Pavel wrote: > Also, consider closing 8255426 as a duplicate. Ha! Thanks, I had forgotten about that one. Easier to file a new bug than to dig out an old one. Oh well, closed as duplicate. - PR: https://git.openjdk.org/jdk19/pull/111
Re: [jdk19] RFR: 8289779: Map::replaceAll javadoc has redundant @throws clauses
On Wed, 6 Jul 2022 00:32:00 GMT, Stuart Marks wrote: > Simple javadoc fix of an editorial nature. Thanks for doing this, Stuart. Not only does this PR remove duplication from the `Map` documentation, but it also ensures that when JDK-6509045 is integrated, that duplication won't spread to `ConcurrentMap`. A bonus of this fix is that the irrelevant mention of "keys" is gone from the description of `NullPointerException`. Also, consider closing 8255426 as a duplicate. - Marked as reviewed by prappo (Reviewer). PR: https://git.openjdk.org/jdk19/pull/111
[jdk19] RFR: 8289779: Map::replaceAll javadoc has redundant @throws clauses
Simple javadoc fix of an editorial nature. - Commit messages: - 8289779: Map::replaceAll javadoc has redundant @throws clauses Changes: https://git.openjdk.org/jdk19/pull/111/files Webrev: https://webrevs.openjdk.org/?repo=jdk19=111=00 Issue: https://bugs.openjdk.org/browse/JDK-8289779 Stats: 9 lines in 1 file changed: 0 ins; 5 del; 4 mod Patch: https://git.openjdk.org/jdk19/pull/111.diff Fetch: git fetch https://git.openjdk.org/jdk19 pull/111/head:pull/111 PR: https://git.openjdk.org/jdk19/pull/111
