Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
On Sat, 17 Dec 2022 08:05:08 GMT, Alan Bateman wrote: >> A batch a trivial fixes to ProblemList tests: >> [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList >> java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 >> [JDK-8298977](https://bugs.openjdk.org/browse/JDK-8298977) ProblemList >> vmTestbase/nsk/stress/strace/strace002.java on 2 platforms >> [JDK-8298978](https://bugs.openjdk.org/browse/JDK-8298978) ProblemList >> vmTestbase/nsk/stress/strace/strace003.java on 2 platforms > > Instead of excluding java/util/concurrent/ExecutorService/CloseTest.java, we > can just comment out the line in the test's DataProvider that produces a > ForkJoinPool. That will allow the t test to exercise the other > implementations until ForkJoinPool shutdown issue is fixed. @AlanBateman - It's only ProblemListed on one platform... - PR: https://git.openjdk.org/jdk20/pull/50
Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
On Fri, 16 Dec 2022 21:02:21 GMT, Daniel D. Daugherty wrote: > A batch a trivial fixes to ProblemList tests: > [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList > java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 > [JDK-8298977](https://bugs.openjdk.org/browse/JDK-8298977) ProblemList > vmTestbase/nsk/stress/strace/strace002.java on 2 platforms > [JDK-8298978](https://bugs.openjdk.org/browse/JDK-8298978) ProblemList > vmTestbase/nsk/stress/strace/strace003.java on 2 platforms Instead of excluding java/util/concurrent/ExecutorService/CloseTest.java, we can just comment out the line in the test's DataProvider that produces a ForkJoinPool. That will allow the t test to exercise the other implementations until ForkJoinPool shutdown issue is fixed. - PR: https://git.openjdk.org/jdk20/pull/50
Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
On Fri, 16 Dec 2022 21:16:38 GMT, Iris Clark wrote: >> A batch a trivial fixes to ProblemList tests: >> [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList >> java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 >> [JDK-8298977](https://bugs.openjdk.org/browse/JDK-8298977) ProblemList >> vmTestbase/nsk/stress/strace/strace002.java on 2 platforms >> [JDK-8298978](https://bugs.openjdk.org/browse/JDK-8298978) ProblemList >> vmTestbase/nsk/stress/strace/strace003.java on 2 platforms > > Marked as reviewed by iris (Reviewer). @irisclark - Thanks for the review! You may not be listed on the integration depending on how the bots are running. - PR: https://git.openjdk.org/jdk20/pull/50
Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
On Fri, 16 Dec 2022 21:13:56 GMT, Kim Barrett wrote: >> A batch a trivial fixes to ProblemList tests: >> [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList >> java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 >> [JDK-8298977](https://bugs.openjdk.org/browse/JDK-8298977) ProblemList >> vmTestbase/nsk/stress/strace/strace002.java on 2 platforms >> [JDK-8298978](https://bugs.openjdk.org/browse/JDK-8298978) ProblemList >> vmTestbase/nsk/stress/strace/strace003.java on 2 platforms > > Looks good. @kimbarrett - Thanks for the fast review! - PR: https://git.openjdk.org/jdk20/pull/50
Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
On Fri, 16 Dec 2022 21:02:21 GMT, Daniel D. Daugherty wrote: > A batch a trivial fixes to ProblemList tests: > [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList > java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 > [JDK-8298977](https://bugs.openjdk.org/browse/JDK-8298977) ProblemList > vmTestbase/nsk/stress/strace/strace002.java on 2 platforms > [JDK-8298978](https://bugs.openjdk.org/browse/JDK-8298978) ProblemList > vmTestbase/nsk/stress/strace/strace003.java on 2 platforms Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk20/pull/50
Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
On Fri, 16 Dec 2022 21:02:21 GMT, Daniel D. Daugherty wrote: > A batch a trivial fixes to ProblemList tests: > [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList > java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 > [JDK-8298977](https://bugs.openjdk.org/browse/JDK-8298977) ProblemList > vmTestbase/nsk/stress/strace/strace002.java on 2 platforms > [JDK-8298978](https://bugs.openjdk.org/browse/JDK-8298978) ProblemList > vmTestbase/nsk/stress/strace/strace003.java on 2 platforms Looks good. - Marked as reviewed by kbarrett (Reviewer). PR: https://git.openjdk.org/jdk20/pull/50
[jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
A batch a trivial fixes to ProblemList tests: [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 [JDK-8298977](https://bugs.openjdk.org/browse/JDK-8298977) ProblemList vmTestbase/nsk/stress/strace/strace002.java on 2 platforms [JDK-8298978](https://bugs.openjdk.org/browse/JDK-8298978) ProblemList vmTestbase/nsk/stress/strace/strace003.java on 2 platforms - Commit messages: - 8298978: ProblemList vmTestbase/nsk/stress/strace/strace003.java on 2 platforms - 8298977: ProblemList vmTestbase/nsk/stress/strace/strace002.java on 2 platforms - 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 Changes: https://git.openjdk.org/jdk20/pull/50/files Webrev: https://webrevs.openjdk.org/?repo=jdk20=50=00 Issue: https://bugs.openjdk.org/browse/JDK-8298976 Stats: 3 lines in 2 files changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk20/pull/50.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/50/head:pull/50 PR: https://git.openjdk.org/jdk20/pull/50
