Re: [jdk23] RFR: 8333748: javap crash - Fatal error: Unmatched bit position 0x2 for location CLASS

2024-06-24 Thread Adam Sotona
On Sat, 22 Jun 2024 00:26:51 GMT, Chen Liang  wrote:

> Please review this clean backport of #19708, to make javap recover and 
> continue after encountering undefined access flag bits set while still 
> exiting with a code of error, allowing it to error against improper bits 
> while still providing as much output as possible.

Marked as reviewed by asotona (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/19839#pullrequestreview-2135714317


[jdk23] RFR: 8333748: javap crash - Fatal error: Unmatched bit position 0x2 for location CLASS

2024-06-21 Thread Chen Liang
Please review this clean backport of #19708, to make javap recover and continue 
after encountering undefined access flag bits set while still exiting with a 
code of error, allowing it to error against improper bits while still providing 
as much output as possible.

-

Commit messages:
 - Backport 7e55ed3b106ed08956d2d38b7c99fb81704667c9

Changes: https://git.openjdk.org/jdk/pull/19839/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19839=00
  Issue: https://bugs.openjdk.org/browse/JDK-8333748
  Stats: 228 lines in 4 files changed: 168 ins; 44 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/19839.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19839/head:pull/19839

PR: https://git.openjdk.org/jdk/pull/19839