Re: [jdk23] RFR: 8333854: IllegalAccessError with proxies after JDK-8332457
On Thu, 20 Jun 2024 20:11:06 GMT, Chen Liang wrote: > Please review this patch, which is a backport of the fix in #19615 to JDK 23. > > This is not a clean patch, because the old patch was done on JDK-8333479 > (#19585) which was absent in JDK 23; however, the conflicts were small, and > the only real changes were that `methodTypeDesc` and `classDesc` from > `ConstantUtils` were not available, so the original approaches were retained. > There is also import adjustments. > > Testing: tier 1-3 It looks good to me, thanks. - Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19815#pullrequestreview-2132482150
[jdk23] RFR: 8333854: IllegalAccessError with proxies after JDK-8332457
Please review this patch, which is a backport of the fix in #19615 to JDK 23. This is not a clean patch, because the old patch was done on JDK-8333479 (#19585) which was absent in JDK 23; however, the conflicts were small, and the only real changes were that `methodTypeDesc` and `classDesc` from `ConstantUtils` were not available, so the original approaches were retained. There is also import adjustments. Testing: tier 1-3 - Commit messages: - 8333854: IllegalAccessError with proxies after JDK-8332457 Changes: https://git.openjdk.org/jdk/pull/19815/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19815=00 Issue: https://bugs.openjdk.org/browse/JDK-8333854 Stats: 238 lines in 2 files changed: 161 ins; 9 del; 68 mod Patch: https://git.openjdk.org/jdk/pull/19815.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19815/head:pull/19815 PR: https://git.openjdk.org/jdk/pull/19815