Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-12-01 Thread Viktor Klang 
On Fri, 1 Dec 2023 14:30:12 GMT, Christian Stein  wrote:

>> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
>
> Seems to be a different issue with "linux-x86" (32-bit host) and 
> `GathererTest::testMassivelyComposedGatherers`.
> 
> https://github.com/sormuras/jdk/actions/runs/7060090092#summary-19219883603

@sormuras That's unfortunate. I'll lower the simulation threshold to give those 
with a stack disadvantage a chance to run that test.

-

PR Comment: https://git.openjdk.org/jdk/pull/16909#issuecomment-1836265115

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-12-01 Thread Christian Stein 
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty  
wrote:

> A trivial fix to ProblemList java/util/stream/GatherersTest.java.

Seems to be a different issue with "linux-x86" (32-bit host) and 
`GathererTest::testMassivelyComposedGatherers`.

https://github.com/sormuras/jdk/actions/runs/7060090092#summary-19219883603

-

PR Comment: https://git.openjdk.org/jdk/pull/16909#issuecomment-1836211653

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-12-01 Thread Christian Stein 
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty  
wrote:

> A trivial fix to ProblemList java/util/stream/GatherersTest.java.

Off by one "s"?

Or does `java/util/stream/GathererTest`  (without "s") fail in addition? 
https://github.com/sormuras/jdk/actions/runs/7058601775#user-content-java_util_stream_gatherertest

-

PR Comment: https://git.openjdk.org/jdk/pull/16909#issuecomment-1835895191

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Viktor Klang 
On Thu, 30 Nov 2023 16:12:04 GMT, Aleksey Shipilev  wrote:

>> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
>
> All right! Hope it would be fixed soon. Trivial.

@shipilev @AlanBateman @dcubed-ojdk I'm on it.

-

PR Comment: https://git.openjdk.org/jdk/pull/16909#issuecomment-1834321347

Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Daniel D . Daugherty 
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty  
wrote:

> A trivial fix to ProblemList java/util/stream/GatherersTest.java.

This pull request has now been integrated.

Changeset: c6a82783
Author:Daniel D. Daugherty 
URL:   
https://git.openjdk.org/jdk/commit/c6a827836277f753652815ce6a6bedd426468b87
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod

8321127: ProblemList java/util/stream/GatherersTest.java

Reviewed-by: shade, alanb

-

PR: https://git.openjdk.org/jdk/pull/16909

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Daniel D . Daugherty 
On Thu, 30 Nov 2023 16:12:04 GMT, Aleksey Shipilev  wrote:

>> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
>
> All right! Hope it would be fixed soon. Trivial.

@shipilev and @AlanBateman - Thanks for the fast reviews.

-

PR Comment: https://git.openjdk.org/jdk/pull/16909#issuecomment-1834087312

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Aleksey Shipilev 
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty  
wrote:

> A trivial fix to ProblemList java/util/stream/GatherersTest.java.

All right! Hope it would be fixed soon. Trivial.

-

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16909#pullrequestreview-1757841717

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Alan Bateman 
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty  
wrote:

> A trivial fix to ProblemList java/util/stream/GatherersTest.java.

Marked as reviewed by alanb (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/16909#pullrequestreview-1757847283

Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Daniel D . Daugherty 
A trivial fix to ProblemList java/util/stream/GatherersTest.java.

-

Commit messages:
 - 8321127: ProblemList java/util/stream/GatherersTest.java

Changes: https://git.openjdk.org/jdk/pull/16909/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk=16909=00
  Issue: https://bugs.openjdk.org/browse/JDK-8321127
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/16909.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16909/head:pull/16909

PR: https://git.openjdk.org/jdk/pull/16909