RFR: 8290359: Ensure that all directory streams are closed in jdk.link
This commit adds try-with-resources for uses of Stream from Files methods that walk directories. - Commit messages: - 8290359: Ensure that all directory streams are closed in jdk.link Changes: https://git.openjdk.org/jdk/pull/9520/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9520&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290359 Stats: 73 lines in 3 files changed: 17 ins; 4 del; 52 mod Patch: https://git.openjdk.org/jdk/pull/9520.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9520/head:pull/9520 PR: https://git.openjdk.org/jdk/pull/9520
Re: RFR: 8290359: Ensure that all directory streams are closed in jdk.link
On Fri, 15 Jul 2022 16:18:17 GMT, Ryan Ernst wrote: > This commit adds try-with-resources for uses of Stream from Files > methods that walk directories. Changes requested by chegar (Reviewer). src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 834: > 832: name.endsWith(".EC") || > 833: name.startsWith("META-INF/SIG-") > 834: ); Trivially, can we please keep the indentation consistent with the previous version. So, align all `name.endsWith` expressions under the 's' from startsWith. - PR: https://git.openjdk.org/jdk/pull/9520
Re: RFR: 8290359: Ensure that all directory streams are closed in jdk.link [v2]
> This commit adds try-with-resources for uses of Stream from Files > methods that walk directories. Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into try_files/jdk.link - fix alignment - 8290359: Ensure that all directory streams are closed in jdk.link This commit adds try-with-resources for uses of Stream from Files methods that walk directories. - Changes: - all: https://git.openjdk.org/jdk/pull/9520/files - new: https://git.openjdk.org/jdk/pull/9520/files/f5d4fd2e..4e9eede0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9520&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9520&range=00-01 Stats: 1454 lines in 71 files changed: 802 ins; 379 del; 273 mod Patch: https://git.openjdk.org/jdk/pull/9520.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9520/head:pull/9520 PR: https://git.openjdk.org/jdk/pull/9520
Re: RFR: 8290359: Ensure that all directory streams are closed in jdk.link [v2]
On Mon, 18 Jul 2022 15:35:25 GMT, Chris Hegarty wrote: >> Ryan Ernst has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Merge branch 'master' into try_files/jdk.link >> - fix alignment >> - 8290359: Ensure that all directory streams are closed in jdk.link >> >>This commit adds try-with-resources for uses of Stream from Files >>methods that walk directories. > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 834: > >> 832: name.endsWith(".EC") || >> 833: name.startsWith("META-INF/SIG-") >> 834: ); > > Trivially, can we please keep the indentation consistent with the previous > version. So, align all `name.endsWith` expressions under the 's' from > startsWith. Done in [c628479](https://github.com/openjdk/jdk/pull/9520/commits/c62847976c4a34ee97be61bbac3002513028e87c) - PR: https://git.openjdk.org/jdk/pull/9520
Re: RFR: 8290359: Ensure that all directory streams are closed in jdk.link [v2]
On Mon, 18 Jul 2022 18:22:02 GMT, Ryan Ernst wrote: >> This commit adds try-with-resources for uses of Stream from Files >> methods that walk directories. > > Ryan Ernst has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Merge branch 'master' into try_files/jdk.link > - fix alignment > - 8290359: Ensure that all directory streams are closed in jdk.link > >This commit adds try-with-resources for uses of Stream from Files >methods that walk directories. LGTM - Marked as reviewed by chegar (Reviewer). PR: https://git.openjdk.org/jdk/pull/9520