Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v7]

2022-11-21 Thread pandaapo 
On Tue, 22 Nov 2022 01:44:29 GMT, Weijun Wang  wrote:

> Everything looks fine now. Thanks so much for the cleanup. It's always nice 
> to see unused lines removed.

Thank you for your review.

-

PR: https://git.openjdk.org/jdk/pull/11072

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v7]

2022-11-21 Thread Weijun Wang 
On Tue, 22 Nov 2022 00:45:00 GMT, pandaapo  wrote:

>> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
>
> pandaapo has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Modify as reviews.

Everything looks fine now. Thanks so much for the cleanup. It's always nice to 
see unused lines removed.

-

Marked as reviewed by weijun (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11072

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v7]

2022-11-21 Thread pandaapo 
> The cache named `signerToCodeSource` in `JarVerifier` is never used now.

pandaapo has updated the pull request incrementally with one additional commit 
since the last revision:

  Modify as reviews.

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/11072/files
  - new: https://git.openjdk.org/jdk/pull/11072/files/fb933804..1aa65b2b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=11072=06
 - incr: https://webrevs.openjdk.org/?repo=jdk=11072=05-06

  Stats: 10 lines in 1 file changed: 4 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/11072.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11072/head:pull/11072

PR: https://git.openjdk.org/jdk/pull/11072