Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]
> Modify the `Space` instances used for size comparison to be created with > total number of bytes derived from the Windows `diskFree` utility instead of > Cygwin’s `df`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8305157: Clean up - Changes: - all: https://git.openjdk.org/jdk/pull/12397/files - new: https://git.openjdk.org/jdk/pull/12397/files/114857c1..9ae317e7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12397&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12397&range=02-03 Stats: 14 lines in 2 files changed: 7 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/12397.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/12397/head:pull/12397 PR: https://git.openjdk.org/jdk/pull/12397
Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]
On Tue, 28 Feb 2023 21:26:55 GMT, Brian Burkhalter wrote: >> Spawning `df` and `diskFree` processes have been replaced with native calls. >> For a reason as yet undetermined, the Windows function >> `GetDiskSpaceInformationW` fails to load on Windows Server 2016 so it is >> loaded dynamically and, if not found, a workaround is used. > > Testing in the CI against the latest commit > 114857c1fbc6ea6ad0ee9ccce10cb886e8c62469 has passed more than 500 iterations > on Windows with no failures. This test has been run successfully hundreds of times on CI system nodes where it previously failed. - PR Review Comment: https://git.openjdk.org/jdk/pull/12397#discussion_r1156138528
Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]
On Wed, 29 Mar 2023 18:05:46 GMT, Brian Burkhalter wrote: >> Modify the `Space` instances used for size comparison to be created with >> total number of bytes derived from the Windows `diskFree` utility instead of >> Cygwin’s `df`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8305157: Clean up LGTM - Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/12397#pullrequestreview-1369424502
Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]
On Wed, 29 Mar 2023 18:05:46 GMT, Brian Burkhalter wrote: >> Modify the `Space` instances used for size comparison to be created with >> total number of bytes derived from the Windows `diskFree` utility instead of >> Cygwin’s `df`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8305157: Clean up It seems after refactoring test started to fail on my Win11 VM. STDOUT: --- Testing volumes Total bytes : 299,877,003,264 (279.3 GB) Total quota free bytes : 202,708,971,520 (188.8 GB) Unavailable pool bytes : 0 ( 0.0 KB) Quota unavailable pool bytes: 0 ( 0.0 KB) Used bytes : 92,833,345,536 ( 86.5 GB) Total Reserved bytes: 4,334,686,208 ( 4.0 GB) Volume storage reserved bytes : 4,296,867,840 ( 4.0 GB) Available committed bytes : 0 ( 0.0 KB) Pool available bytes: 0 ( 0.0 KB) SecurityManager = null C:\ (299877003264): getSpace0 total = 299877003264 free = 202708967424 usable = 202708967424 getXSpace total = 299877003264 free = 202708967424 usable = 202708967424 STDERR: WARNING: A terminally deprecated method in java.lang.System has been called WARNING: System::setSecurityManager has been called by GetXSpace (file:/C:/Projects/jdk/build/windows-x86_64-server-slowdebug/test-support/jtreg_test_jdk_java_io_File/classes/2/java/io/File/GetXSpace.d/) WARNING: Please consider reporting this to the maintainers of GetXSpace WARNING: System::setSecurityManager will be removed in a future release java.lang.RuntimeException: The parameter is incorrect at GetXSpace.getSpace0(Native Method) at GetXSpace$Space.(GetXSpace.java:112) at GetXSpace.testVolumes(GetXSpace.java:431) at GetXSpace.main(GetXSpace.java:469) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) at java.base/java.lang.Thread.run(Thread.java:1570) JavaTest Message: Test threw exception: java.lang.RuntimeException: The parameter is incorrect - PR Comment: https://git.openjdk.org/jdk/pull/12397#issuecomment-1705164515
Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]
The changes to this test were developed on a native Windows 11 machine. I have never seen this problem. A web search suggests that this is a Windows error message possibly due to drive error. On Sep 4, 2023, at 5:16 AM, Andrey Turbanov mailto:aturba...@openjdk.org>> wrote: It seems after refactoring test started to fail on my Win11 VM. […] java.lang.RuntimeException: The parameter is incorrect at GetXSpace.getSpace0(Native Method) at GetXSpace$Space.(GetXSpace.java:112)
