Re: RFR: 8307818: Convert Indify tool to Classfile API [v3]
On Mon, 20 May 2024 13:20:17 GMT, Oussama Louati wrote:
>> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code
>> private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle,
>> MethodType, and CallSite constants.
>> It currently uses ad-hoc code to process class files and intends to migrate
>> to ASM; but since we have the Classfile API, we can migrate to Classfile API
>> instead.
>
> Oussama Louati has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove: remove unnecessary ClassModel fields
test/jdk/java/lang/invoke/indify/Indify.java line 352:
> 350: }
> 351:
> 352: public void indifyJar(File f, Object dest){
Suggestion:
public void indifyJar(File f, Object dest) {
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18841#discussion_r1606931520
Re: RFR: 8307818: Convert Indify tool to Classfile API [v3]
> An indify tool in j.l.i tests (also in vmTestBase) convert some source-code > private static methods with MT_ MH_, and INDY_ prefixes into MethodHandle, > MethodType, and CallSite constants. > It currently uses ad-hoc code to process class files and intends to migrate > to ASM; but since we have the Classfile API, we can migrate to Classfile API > instead. Oussama Louati has updated the pull request incrementally with one additional commit since the last revision: remove: remove unnecessary ClassModel fields - Changes: - all: https://git.openjdk.org/jdk/pull/18841/files - new: https://git.openjdk.org/jdk/pull/18841/files/96e6920a..040e925b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18841&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18841&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18841.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18841/head:pull/18841 PR: https://git.openjdk.org/jdk/pull/18841
