Re: RFR: 8307961: java/foreign/enablenativeaccess/TestEnableNativeAccess.java fails with ShouldNotReachHere
On Thu, 11 May 2023 21:29:51 GMT, Maurizio Cimadamore wrote: > This patch fixes the JNI test for the enable native access flag, which was > updated incorrectly as part of https://git.openjdk.org/jdk/pull/13863. > > The problem is that the test doesn't make global references out of the local > ones before sharing them with another thread. > > I could reproduce the failure locally with `-Xcheck:jni`. With this patch, > the test passes. Marked as reviewed by jvernee (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13944#pullrequestreview-1423593045
RFR: 8307961: java/foreign/enablenativeaccess/TestEnableNativeAccess.java fails with ShouldNotReachHere
This patch fixes the JNI test for the enable native access flag, which was updated incorrectly as part of https://git.openjdk.org/jdk/pull/13863. The problem is that the test doesn't make global references out of the local ones before sharing them with another thread. I could reproduce the failure locally with `-Xcheck:jni`. With this patch, the test passes. - Commit messages: - Initial push Changes: https://git.openjdk.org/jdk/pull/13944/files Webrev: https://webrevs.openjdk.org/?repo=jdk=13944=00 Issue: https://bugs.openjdk.org/browse/JDK-8307961 Stats: 8 lines in 1 file changed: 3 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/13944.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13944/head:pull/13944 PR: https://git.openjdk.org/jdk/pull/13944