Re: RFR: 8308452: Extend internal Architecture enum with byte order and address size [v4]
On Wed, 31 May 2023 18:25:18 GMT, Roger Riggs wrote: >> The internal enum jdk.internal.util.Architecture does not provide >> information about the big or little endianness or the address size (64 or 32 >> bits). The endian-ness and address size are intrinsic to the architecture. >> >> The values of the enum are extended to separately identify the big endian >> and little-endian uses of the ISA. >> For example, `PPC64` and `PPC64LE` for the big and little-endian versions. >> The enum values directly reflect the build-time artifacts and resulting >> executables. >> >> This information about an architecture will make the enum more useful >> especially to identify a target platform in a cross-platform use case. A >> method is added to map well known aliases for the platforms to the >> Architecture enum. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Remove duplicate import Thanks for the updates! LGTM. - Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14063#pullrequestreview-1454964630
Re: RFR: 8308452: Extend internal Architecture enum with byte order and address size [v4]
> The internal enum jdk.internal.util.Architecture does not provide information > about the big or little endianness or the address size (64 or 32 bits). The > endian-ness and address size are intrinsic to the architecture. > > The values of the enum are extended to separately identify the big endian and > little-endian uses of the ISA. > For example, `PPC64` and `PPC64LE` for the big and little-endian versions. > The enum values directly reflect the build-time artifacts and resulting > executables. > > This information about an architecture will make the enum more useful > especially to identify a target platform in a cross-platform use case. A > method is added to map well known aliases for the platforms to the > Architecture enum. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Remove duplicate import - Changes: - all: https://git.openjdk.org/jdk/pull/14063/files - new: https://git.openjdk.org/jdk/pull/14063/files/a6abcdfe..aafcc7de Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=14063=03 - incr: https://webrevs.openjdk.org/?repo=jdk=14063=02-03 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/14063.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14063/head:pull/14063 PR: https://git.openjdk.org/jdk/pull/14063
