Re: RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v7]
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`. > > `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM > error occurs it can not recover scoped values. > > Moving `runWith()` into the common subclass of both `VirtualThread` and > `BoundVirtualThread` fixes the problem. Andrew Haley has updated the pull request incrementally with one additional commit since the last revision: Don't share ThreadLocalRandom instance, cleanup. - Changes: - all: https://git.openjdk.org/jdk/pull/14399/files - new: https://git.openjdk.org/jdk/pull/14399/files/cded1566..b2663471 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14399&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14399&range=05-06 Stats: 18 lines in 1 file changed: 0 ins; 7 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/14399.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14399/head:pull/14399 PR: https://git.openjdk.org/jdk/pull/14399
Re: RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v7]
On Thu, 15 Jun 2023 11:11:18 GMT, Andrew Haley wrote: >> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`. >> >> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM >> error occurs it can not recover scoped values. >> >> Moving `runWith()` into the common subclass of both `VirtualThread` and >> `BoundVirtualThread` fixes the problem. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Don't share ThreadLocalRandom instance, cleanup. I'd probably go further and drop the TLR parameter from the choose method too but what you have is fine, let's go with that. - Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14399#pullrequestreview-1481324158
