Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276
On Wed, 24 May 2023 13:44:40 GMT, Martin Doerr wrote: >> Do you prefer removing it? > > I think it's not important. I'll just integrate it to get the tests working > again. Yeah, let's integrate - PR Review Comment: https://git.openjdk.org/jdk/pull/14116#discussion_r1204172106
Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276
On Wed, 24 May 2023 12:56:55 GMT, Martin Doerr wrote: >> It's probably not required. It was derived from a jextract generated file. > > Do you prefer removing it? I think it's not important. I'll just integrate it to get the tests working again. - PR Review Comment: https://git.openjdk.org/jdk/pull/14116#discussion_r1204170274
Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276
On Wed, 24 May 2023 12:11:09 GMT, Maurizio Cimadamore wrote: > Looks good - I apologize for having missed it. It was my mistake when merging with your change. Thanks for the reviews! I think I should integrate it soon in order to get the tests working again. - PR Comment: https://git.openjdk.org/jdk/pull/14116#issuecomment-1561118118
Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276
On Wed, 24 May 2023 09:16:46 GMT, Martin Doerr wrote: > Please review this trivial adaptation for JDK-8308276. Marked as reviewed by mbaesken (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14116#pullrequestreview-1441800497
Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276
On Wed, 24 May 2023 12:48:00 GMT, Martin Doerr wrote: >> test/jdk/java/foreign/TestHFA.java line 53: >> >>> 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup(); >>> 52: >>> 53: static final OfFloat FLOAT = JAVA_FLOAT.withByteAlignment(4); >> >> Is this even required - e.g. the alignment of Java float is 4 bytes... > > It's probably not required. It was derived from a jextract generated file. Do you prefer removing it? - PR Review Comment: https://git.openjdk.org/jdk/pull/14116#discussion_r1204083863
Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276
On Wed, 24 May 2023 12:12:25 GMT, Maurizio Cimadamore wrote: >> Please review this trivial adaptation for JDK-8308276. > > test/jdk/java/foreign/TestHFA.java line 53: > >> 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup(); >> 52: >> 53: static final OfFloat FLOAT = JAVA_FLOAT.withByteAlignment(4); > > Is this even required - e.g. the alignment of Java float is 4 bytes... It's probably not required. It was derived from a jextract generated file. - PR Review Comment: https://git.openjdk.org/jdk/pull/14116#discussion_r1204069281
Re: RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276
On Wed, 24 May 2023 09:16:46 GMT, Martin Doerr wrote: > Please review this trivial adaptation for JDK-8308276. Looks good - I apologize for having missed it. test/jdk/java/foreign/TestHFA.java line 53: > 51: final static SymbolLookup lookup = SymbolLookup.loaderLookup(); > 52: > 53: static final OfFloat FLOAT = JAVA_FLOAT.withByteAlignment(4); Is this even required - e.g. the alignment of Java float is 4 bytes... - Marked as reviewed by mcimadamore (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14116#pullrequestreview-1441682588 PR Review Comment: https://git.openjdk.org/jdk/pull/14116#discussion_r1204006404
RFR: 8308761: New test TestHFA needs adaptation for JDK-8308276
Please review this trivial adaptation for JDK-8308276. - Commit messages: - 8308761: New test TestHFA needs adaptation for JDK-8308276 Changes: https://git.openjdk.org/jdk/pull/14116/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14116&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308761 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/14116.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14116/head:pull/14116 PR: https://git.openjdk.org/jdk/pull/14116
