Re: RFR: 8310643: Misformatted copyright messages in FFM [v3]
> This PR suggests updating some of the ill-formed copyright headers in the FFM > API and the implementation and test thereof. > > Some of the test files will have now the "classpath" exception. Is this > correct? Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Restore removed test definition - Changes: - all: https://git.openjdk.org/jdk/pull/15042/files - new: https://git.openjdk.org/jdk/pull/15042/files/d81d0c4e..c0a50714 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=15042=02 - incr: https://webrevs.openjdk.org/?repo=jdk=15042=01-02 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/15042.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15042/head:pull/15042 PR: https://git.openjdk.org/jdk/pull/15042
Re: RFR: 8310643: Misformatted copyright messages in FFM [v3]
On Mon, 7 Aug 2023 10:53:20 GMT, Per Minborg wrote: >> This PR suggests updating some of the ill-formed copyright headers in the >> FFM API and the implementation and test thereof. >> >> Some of the test files will have now the "classpath" exception. Is this >> correct? > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Restore removed test definition Marked as reviewed by jvernee (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15042#pullrequestreview-1565069902
Re: RFR: 8310643: Misformatted copyright messages in FFM [v2]
On Mon, 7 Aug 2023 08:57:56 GMT, Per Minborg wrote: >> This PR suggests updating some of the ill-formed copyright headers in the >> FFM API and the implementation and test thereof. >> >> Some of the test files will have now the "classpath" exception. Is this >> correct? > > Per Minborg has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove classpath exception from test files > - Add classpath exception to some internal files test/jdk/java/foreign/TestIllegalLink.java line 30: > 28: * @requires jdk.foreign.linker != "UNSUPPORTED" > 29: * @modules java.base/jdk.internal.foreign > 30: * @run testng/othervm --enable-native-access=ALL-UNNAMED TestIllegalLink This is removing the jtreg test. - PR Review Comment: https://git.openjdk.org/jdk/pull/15042#discussion_r1285595093
Re: RFR: 8310643: Misformatted copyright messages in FFM [v2]
> This PR suggests updating some of the ill-formed copyright headers in the FFM > API and the implementation and test thereof. > > Some of the test files will have now the "classpath" exception. Is this > correct? Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Remove classpath exception from test files - Add classpath exception to some internal files - Changes: - all: https://git.openjdk.org/jdk/pull/15042/files - new: https://git.openjdk.org/jdk/pull/15042/files/3389537c..d81d0c4e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=15042=01 - incr: https://webrevs.openjdk.org/?repo=jdk=15042=00-01 Stats: 135 lines in 45 files changed: 8 ins; 82 del; 45 mod Patch: https://git.openjdk.org/jdk/pull/15042.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15042/head:pull/15042 PR: https://git.openjdk.org/jdk/pull/15042
Re: RFR: 8310643: Misformatted copyright messages in FFM
On Sat, 29 Jul 2023 12:29:13 GMT, David Holmes wrote: >> This PR suggests updating some of the ill-formed copyright headers in the >> FFM API and the implementation and test thereof. >> >> Some of the test files will have now the "classpath" exception. Is this >> correct? > > src/java.base/share/classes/java/lang/foreign/GroupLayout.java line 25: > >> 23: * questions. >> 24: */ >> 25: > > Is there some style guideline that says there needs to be a blank line here? This is common for many JDK files. - PR Review Comment: https://git.openjdk.org/jdk/pull/15042#discussion_r1285558048
Re: RFR: 8310643: Misformatted copyright messages in FFM
On Wed, 26 Jul 2023 15:43:12 GMT, Per Minborg wrote: > This PR suggests updating some of the ill-formed copyright headers in the FFM > API and the implementation and test thereof. > > Some of the test files will have now the "classpath" exception. Is this > correct? src/java.base/share/classes/java/lang/foreign/GroupLayout.java line 25: > 23: * questions. > 24: */ > 25: Is there some style guideline that says there needs to be a blank line here? - PR Review Comment: https://git.openjdk.org/jdk/pull/15042#discussion_r1278292345
Re: RFR: 8310643: Misformatted copyright messages in FFM
On Wed, 26 Jul 2023 15:43:12 GMT, Per Minborg wrote: > This PR suggests updating some of the ill-formed copyright headers in the FFM > API and the implementation and test thereof. > > Some of the test files will have now the "classpath" exception. Is this > correct? Hi @minborg, Would you add below patch in this PR. This will add "classpath" exception copyright header for some files in java/lang/foreign dir. I have reverted the changes from my [PR](https://github.com/openjdk/jdk/pull/15070/commits/3958d9fe3a5fca3edebdf68ea7e082dd4768ce2f) as @mcimadamore suggested. [java_lang_foreign_CP_exception.patch](https://github.com/openjdk/jdk/files/12196879/java_lang_foreign_CP_exception.patch) - PR Comment: https://git.openjdk.org/jdk/pull/15042#issuecomment-1656095047
Re: RFR: 8310643: Misformatted copyright messages in FFM
On Wed, 26 Jul 2023 19:28:04 GMT, Jorn Vernee wrote: >> This PR suggests updating some of the ill-formed copyright headers in the >> FFM API and the implementation and test thereof. >> >> Some of the test files will have now the "classpath" exception. Is this >> correct? > >> Some of the test files will have now the "classpath" exception. Is this >> correct? > > No. The test files should not have the classpath exception. Thanks for looking into this. As commented by @JornVernee, it is deliberate that tests do not have CP exception. So the fix there is the opposite: we should be looking for text with the exception text, and drop it. - PR Comment: https://git.openjdk.org/jdk/pull/15042#issuecomment-1652736990
Re: RFR: 8310643: Misformatted copyright messages in FFM
On Wed, 26 Jul 2023 15:43:12 GMT, Per Minborg wrote: > Some of the test files will have now the "classpath" exception. Is this > correct? No. The test files should not have the classpath exception. - PR Comment: https://git.openjdk.org/jdk/pull/15042#issuecomment-1652367609
RFR: 8310643: Misformatted copyright messages in FFM
This PR suggests updating some of the ill-formed copyright headers in the FFM API and the implementation and test thereof. Some of the test files will have now the "classpath" exception. Is this correct? - Commit messages: - Update copyright formatting Changes: https://git.openjdk.org/jdk/pull/15042/files Webrev: https://webrevs.openjdk.org/?repo=jdk=15042=00 Issue: https://bugs.openjdk.org/browse/JDK-8310643 Stats: 1083 lines in 54 files changed: 169 ins; 114 del; 800 mod Patch: https://git.openjdk.org/jdk/pull/15042.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15042/head:pull/15042 PR: https://git.openjdk.org/jdk/pull/15042
