Re: RFR: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set [v3]
On Wed, 13 Sep 2023 20:21:20 GMT, Justin Lu wrote: >> Please review this PR which is a continuation of >> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused >> code from the _sun.util.Calendar_ classes. >> >> `forceStandardTime` is always false. >> >> In addition, `locale` is never by used by _CalendarDate_ or any inheritors >> and can be removed. >> >> As a result, _ImmutableGregorianDate_ no longer needs to override the >> _setLocale_ method and throw UnsupportedOperationException. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Reflect review comments Marked as reviewed by aturbanov (Committer). - PR Review: https://git.openjdk.org/jdk/pull/15726#pullrequestreview-1625404590
Re: RFR: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set [v3]
> Please review this PR which is a continuation of > [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused > code from the _sun.util.Calendar_ classes. > > `forceStandardTime` is always false. > > In addition, `locale` is never by used by _CalendarDate_ or any inheritors > and can be removed. > > As a result, _ImmutableGregorianDate_ no longer needs to override the > _setLocale_ method and throw UnsupportedOperationException. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Reflect review comments - Changes: - all: https://git.openjdk.org/jdk/pull/15726/files - new: https://git.openjdk.org/jdk/pull/15726/files/91bd5a3f..5a3375ec Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15726&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15726&range=01-02 Stats: 5 lines in 1 file changed: 1 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/15726.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15726/head:pull/15726 PR: https://git.openjdk.org/jdk/pull/15726
