Re: RFR: 8314330: java/foreign tests should respect vm flags when start new processes [v2]

2023-08-16 Thread Leonid Mesnik 
> The test helper which spawn new jvms is updated to start them using VM flags 
> for testing.

Leonid Mesnik has updated the pull request incrementally with one additional 
commit since the last revision:

  fixed imports.

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/15302/files
  - new: https://git.openjdk.org/jdk/pull/15302/files/27f5eb83..23184fc1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=15302=01
 - incr: https://webrevs.openjdk.org/?repo=jdk=15302=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/15302.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15302/head:pull/15302

PR: https://git.openjdk.org/jdk/pull/15302

Re: RFR: 8314330: java/foreign tests should respect vm flags when start new processes

2023-08-16 Thread Jorn Vernee 
On Wed, 16 Aug 2023 00:14:47 GMT, Leonid Mesnik  wrote:

> The test helper which spawn new jvms is updated to start them using VM flags 
> for testing.

Marked as reviewed by jvernee (Reviewer).

test/jdk/java/foreign/UpcallTestHelper.java line 25:

> 23: 
> 24: import jdk.test.lib.process.ProcessTools;
> 25: import jdk.test.lib.Utils;

Looks like the `Utils` and `Paths` imports are no longer needed now.

-

PR Review: https://git.openjdk.org/jdk/pull/15302#pullrequestreview-1580468855
PR Review Comment: https://git.openjdk.org/jdk/pull/15302#discussion_r1295812282

RFR: 8314330: java/foreign tests should respect vm flags when start new processes

2023-08-15 Thread Leonid Mesnik 
The test helper which spawn new jvms is updated to start them using VM flags 
for testing.

-

Commit messages:
 - 8314330: java/foreign tests should respect vm flags when start new processes

Changes: https://git.openjdk.org/jdk/pull/15302/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk=15302=00
  Issue: https://bugs.openjdk.org/browse/JDK-8314330
  Stats: 10 lines in 1 file changed: 1 ins; 7 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/15302.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15302/head:pull/15302

PR: https://git.openjdk.org/jdk/pull/15302