Re: RFR: 8317141: Remove unused validIndex method from URLClassPath$JarLoader
On Fri, 29 Sep 2023 05:41:11 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes unused (internal) > method from the `private` `URLClassPath$JarLoader`? > > The `validIndex` method which is being removed here was being used when JAR > index was supported. We removed support for JAR index in > https://bugs.openjdk.org/browse/JDK-8302819. This method is now a leftover > and no longer used. > > The commit in this PR also removes a couple of other member fields in > `URLClassPath$JarLoader`. These fields too were used previously when JAR > index was in use and are no longer used. > > tier1, tier2 and tier3 tests continue to pass with this change. Thank you all for the reviews. - PR Comment: https://git.openjdk.org/jdk/pull/15976#issuecomment-1741612815
Re: RFR: 8317141: Remove unused validIndex method from URLClassPath$JarLoader
On Fri, 29 Sep 2023 05:41:11 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes unused (internal) > method from the `private` `URLClassPath$JarLoader`? > > The `validIndex` method which is being removed here was being used when JAR > index was supported. We removed support for JAR index in > https://bugs.openjdk.org/browse/JDK-8302819. This method is now a leftover > and no longer used. > > The commit in this PR also removes a couple of other member fields in > `URLClassPath$JarLoader`. These fields too were used previously when JAR > index was in use and are no longer used. > > tier1, tier2 and tier3 tests continue to pass with this change. Looks reasonable to me. - Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15976#pullrequestreview-1650562494
Re: RFR: 8317141: Remove unused validIndex method from URLClassPath$JarLoader
On Fri, 29 Sep 2023 05:41:11 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes unused (internal) > method from the `private` `URLClassPath$JarLoader`? > > The `validIndex` method which is being removed here was being used when JAR > index was supported. We removed support for JAR index in > https://bugs.openjdk.org/browse/JDK-8302819. This method is now a leftover > and no longer used. > > The commit in this PR also removes a couple of other member fields in > `URLClassPath$JarLoader`. These fields too were used previously when JAR > index was in use and are no longer used. > > tier1, tier2 and tier3 tests continue to pass with this change. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15976#pullrequestreview-1650499922
Re: RFR: 8317141: Remove unused validIndex method from URLClassPath$JarLoader
On Fri, 29 Sep 2023 05:41:11 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes unused (internal) > method from the `private` `URLClassPath$JarLoader`? > > The `validIndex` method which is being removed here was being used when JAR > index was supported. We removed support for JAR index in > https://bugs.openjdk.org/browse/JDK-8302819. This method is now a leftover > and no longer used. > > The commit in this PR also removes a couple of other member fields in > `URLClassPath$JarLoader`. These fields too were used previously when JAR > index was in use and are no longer used. > > tier1, tier2 and tier3 tests continue to pass with this change. Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15976#pullrequestreview-1650122830
RFR: 8317141: Remove unused validIndex method from URLClassPath$JarLoader
Can I please get a review of this change which removes unused (internal) method from the `private` `URLClassPath$JarLoader`? The `validIndex` method which is being removed here was being used when JAR index was supported. We removed support for JAR index in https://bugs.openjdk.org/browse/JDK-8302819. This method is now a leftover and no longer used. The commit in this PR also removes a couple of other member fields in `URLClassPath$JarLoader`. These fields too were used previously when JAR index was in use and are no longer used. tier1, tier2 and tier3 tests continue to pass with this change. - Commit messages: - 8317141: Remove unused validIndex method from URLClassPath Changes: https://git.openjdk.org/jdk/pull/15976/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15976&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317141 Stats: 41 lines in 1 file changed: 0 ins; 38 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/15976.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15976/head:pull/15976 PR: https://git.openjdk.org/jdk/pull/15976
