Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v4]

2023-12-20 Thread Weibing Xiao
> Better Error Handling for Jar Tool Processing of "@File" 
> 
> This is a new PR for this PR since the original developer left the team. See 
> all of the review history at https://github.com/openjdk/jdk/pull/16423.
> 
> Thank you.

Weibing Xiao has updated the pull request incrementally with one additional 
commit since the last revision:

  update the test cases

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/17088/files
  - new: https://git.openjdk.org/jdk/pull/17088/files/ba9335e0..ff349833

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17088&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17088&range=02-03

  Stats: 39 lines in 1 file changed: 35 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/17088.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17088/head:pull/17088

PR: https://git.openjdk.org/jdk/pull/17088


Re: RFR: 8318971 : Better Error Handling for Jar Tool When Processing Non-existent Files [v4]

2023-12-20 Thread Jaikiran Pai
On Wed, 20 Dec 2023 16:29:59 GMT, Weibing Xiao  wrote:

>> Better Error Handling for Jar Tool Processing of "@File" 
>> 
>> This is a new PR for this PR since the original developer left the team. See 
>> all of the review history at https://github.com/openjdk/jdk/pull/16423.
>> 
>> Thank you.
>
> Weibing Xiao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   update the test cases

Marked as reviewed by jpai (Reviewer).

The current state in `ff349833` looks good to me. Thank you for these updates. 
Please run tier1, tier2, tier3 before integrating.

-

PR Review: https://git.openjdk.org/jdk/pull/17088#pullrequestreview-1792326348
PR Comment: https://git.openjdk.org/jdk/pull/17088#issuecomment-1865680335