Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v12]

[Andrey Turbanov]

On Fri, 17 Nov 2023 18:46:57 GMT, Andrey Turbanov  wrote:

>> Viktor Klang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Addressing trailing whitespace complaint
>
> src/java.base/share/classes/java/util/stream/GathererOp.java line 297:
> 
>> 295:  * There's a very small subset of possible Gatherers which 
>> would be
>> 296:  * expressible as Spliterators directly,
>> 297:  * - the Gatherer's initializer is 
>> Gatherer.defaultInitiatizer(),
> 
> typo
> Suggestion:
> 
>  * - the Gatherer's initializer is Gatherer.defaultInitializer(),

Let's fix at least a typo

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1410495723

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v12]

[Andrey Turbanov]

On Fri, 17 Nov 2023 13:15:12 GMT, Viktor Klang  wrote:

>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing trailing whitespace complaint

src/java.base/share/classes/java/util/stream/GathererOp.java line 475:

> 473: }
> 474: 
> 475: protected Hybrid(Spliterator spliterator) {

Suggestion:

Hybrid(Spliterator spliterator) {

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397739607

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v12]

[Andrey Turbanov]

On Fri, 17 Nov 2023 13:15:12 GMT, Viktor Klang  wrote:

>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing trailing whitespace complaint

src/java.base/share/classes/java/util/stream/GathererOp.java line 297:

> 295:  * There's a very small subset of possible Gatherers which would 
> be
> 296:  * expressible as Spliterators directly,
> 297:  * - the Gatherer's initializer is Gatherer.defaultInitiatizer(),

typo
Suggestion:

 * - the Gatherer's initializer is Gatherer.defaultInitializer(),

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397736608

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v12]

[Andrey Turbanov]

On Fri, 17 Nov 2023 13:15:12 GMT, Viktor Klang  wrote:

>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing trailing whitespace complaint

src/java.base/share/classes/java/util/stream/Gatherers.java line 492:

> 490: @Override BiConsumer> finisher) 
> implements Gatherer {
> 491: 
> 492: static  GathererImpl of(

method seems unused

src/java.base/share/classes/java/util/stream/Gatherers.java line 564:

> 562: }
> 563: 
> 564: static final  GathererImpl impl(

nit
Suggestion:

static  GathererImpl impl(

src/java.base/share/classes/java/util/stream/ReferencePipeline.java line 710:

> 708: 
> 709: @Override
> 710: public  R collect(Supplier supplier,

alignment of parameters is lost here

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397723227
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397723825
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397725659

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v12]

[Andrey Turbanov]

On Fri, 17 Nov 2023 13:15:12 GMT, Viktor Klang  wrote:

>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing trailing whitespace complaint

src/java.base/share/classes/java/util/stream/Gatherer.java line 214:

> 212: default Supplier initializer() {
> 213: return defaultInitializer();
> 214: };

Suggestion:

}

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397691817

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v12]

[Viktor Klang]

On Fri, 17 Nov 2023 13:11:13 GMT, Viktor Klang  wrote:

>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing trailing whitespace complaint

src/java.base/share/classes/java/util/stream/Gatherer.java line 118:

> 116:  * }
> 117:  *
> 118:  * As an example, a Gatherer implementing a sequential Prefix Scan 
> could

@AlanBateman @PaulSandoz Somehow having a trailing space after "Scan" was 
preventing integration-ability of this PR. Apologies.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1397281491

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v12]

[Viktor Klang]

> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)

Viktor Klang has updated the pull request incrementally with one additional 
commit since the last revision:

  Addressing trailing whitespace complaint

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/16420/files
  - new: https://git.openjdk.org/jdk/pull/16420/files/080bd484..48b7e329

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=16420=11
 - incr: https://webrevs.openjdk.org/?repo=jdk=16420=10-11

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/16420.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16420/head:pull/16420

PR: https://git.openjdk.org/jdk/pull/16420