Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v9]
On Thu, 16 Nov 2023 00:22:04 GMT, Paul Sandoz wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improvements after feedback > > Elegantly and thoroughly done (I mostly focused on the API and > implementation). I have been following the work and providing ongoing > feedback hence no specific comments here. > > Going preview now will allow for some additional time and feedback on the > ergonomics of Gatherer construction. There is also the intriguing prospect of > further work to replace stream internals if the performance holds up (the > ability to optimize when composing gathers seems key here as you already have > explored in the performance tests - the runtime compiler should be able to > see through the shorter paths more easily). @PaulSandoz @AlanBateman This PR is now ready for final review approval (AFAIK). - PR Comment: https://git.openjdk.org/jdk/pull/16420#issuecomment-1816411875
Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v9]
On Thu, 16 Nov 2023 07:51:46 GMT, Alan Bateman wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improvements after feedback > > Really nicely done. @AlanBateman @PaulSandoz Thank you so much! I just pushed a minor clarification regarding the statefulness of `Stream#gather`, a more graceful allocation strategy for `Gatherers.mapConcurrent`, and updated the CSR. I foresee no further changes. - PR Comment: https://git.openjdk.org/jdk/pull/16420#issuecomment-1813964064
Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v9]
On Wed, 15 Nov 2023 17:50:48 GMT, Viktor Klang wrote: >> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Improvements after feedback Really nicely done. - Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16420#pullrequestreview-1733713548
Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v9]
On Wed, 15 Nov 2023 17:50:48 GMT, Viktor Klang wrote: >> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Improvements after feedback Elegantly and thoroughly done (I mostly focused on the API and implementation). I have been following the work and providing ongoing feedback hence no specific comments here. Going preview now will allow for some additional time and feedback on the ergonomics of Gatherer construction. There is also the intriguing prospect of further work to replace stream internals if the performance holds up (the ability to optimize when composing gathers seems key here as you already have explored in the performance tests - the runtime compiler should be able to see through the shorter paths more easily). - Marked as reviewed by psandoz (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16420#pullrequestreview-1733265473
Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v9]
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Improvements after feedback - Changes: - all: https://git.openjdk.org/jdk/pull/16420/files - new: https://git.openjdk.org/jdk/pull/16420/files/bc8f2364..ba84335e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16420&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16420&range=07-08 Stats: 57 lines in 2 files changed: 17 ins; 18 del; 22 mod Patch: https://git.openjdk.org/jdk/pull/16420.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16420/head:pull/16420 PR: https://git.openjdk.org/jdk/pull/16420
