Re: RFR: 8320448: Accelerate IndexOf using AVX2 [v27]
On Wed, 22 May 2024 20:36:25 GMT, Sandhya Viswanathan wrote: >> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert last change to IndexOf.java > > src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1218: > >> 1216: // isU - true if argument encoding is either UU or UL >> 1217: // eq_mask - The bit mask returned that holds the result of the >> comparison >> 1218: // needleLen - a temporary register. Only used if isUL true > > needleLen is not a temporary register. needleLen is used to read the kThByte > from haystack below when !sizeKnown so must hold valid info. Fixed. > src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1439: > >> 1437: // back to last valid read position >> 1438: __ cmpq(hsPtrRet, last); >> 1439: __ jb_b(L_midLoop); > > could be jbe_b? Fixed. - PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1614127526 PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1614127356
Re: RFR: 8320448: Accelerate IndexOf using AVX2 [v27]
On Wed, 22 May 2024 18:52:27 GMT, Scott Gibbons wrote: >> Re-write the IndexOf code without the use of the pcmpestri instruction, only >> using AVX2 instructions. This change accelerates String.IndexOf on average >> 1.3x for AVX2. The benchmark numbers: >> >> >> Benchmark Score >> Latest >> StringIndexOf.advancedWithMediumSub 343.573317.934 >> 0.925375393x >> StringIndexOf.advancedWithShortSub11039.081 1053.96 >> 1.014319384x >> StringIndexOf.advancedWithShortSub255.828110.541 >> 1.980027943x >> StringIndexOf.constantPattern9.361 11.906 >> 1.271872663x >> StringIndexOf.searchCharLongSuccess 4.216 4.218 >> 1.000474383x >> StringIndexOf.searchCharMediumSuccess3.133 3.216 >> 1.02649218x >> StringIndexOf.searchCharShortSuccess 3.763.761 >> 1.000265957x >> StringIndexOf.success9.186 >> 9.713 1.057369911x >> StringIndexOf.successBig 14.34146.343 >> 3.231504079x >> StringIndexOfChar.latin1_AVX2_String 6220.918 12154.52 >> 1.953814533x >> StringIndexOfChar.latin1_AVX2_char 5503.556 5540.044 >> 1.006629895x >> StringIndexOfChar.latin1_SSE4_String 6978.854 6818.689 >> 0.977049957x >> StringIndexOfChar.latin1_SSE4_char 5657.499 5474.624 >> 0.967675646x >> StringIndexOfChar.latin1_Short_String 7132.541 >> 6863.3590.962260014x >> StringIndexOfChar.latin1_Short_char 16013.389 16162.437 >> 1.009307711x >> StringIndexOfChar.latin1_mixed_String 7386.12314771.622 >> 1.15517x >> StringIndexOfChar.latin1_mixed_char9901.671 9782.245 >> 0.987938803 > > Scott Gibbons has updated the pull request incrementally with one additional > commit since the last revision: > > Revert last change to IndexOf.java src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1218: > 1216: // isU - true if argument encoding is either UU or UL > 1217: // eq_mask - The bit mask returned that holds the result of the > comparison > 1218: // needleLen - a temporary register. Only used if isUL true needleLen is not a temporary register. needleLen is used to read the kThByte from haystack below when !sizeKnown so must hold valid info. src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1439: > 1437: // back to last valid read position > 1438: __ cmpq(hsPtrRet, last); > 1439: __ jb_b(L_midLoop); could be jbe_b? - PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1610617943 PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1610740998
Re: RFR: 8320448: Accelerate IndexOf using AVX2 [v27]
> Re-write the IndexOf code without the use of the pcmpestri instruction, only > using AVX2 instructions. This change accelerates String.IndexOf on average > 1.3x for AVX2. The benchmark numbers: > > > BenchmarkScore > Latest > StringIndexOf.advancedWithMediumSub 343.573 317.934 > 0.925375393x > StringIndexOf.advancedWithShortSub1 1039.081 1053.96 > 1.014319384x > StringIndexOf.advancedWithShortSub2 55.828110.541 > 1.980027943x > StringIndexOf.constantPattern 9.361 11.906 > 1.271872663x > StringIndexOf.searchCharLongSuccess 4.216 4.218 > 1.000474383x > StringIndexOf.searchCharMediumSuccess 3.133 3.216 > 1.02649218x > StringIndexOf.searchCharShortSuccess 3.763.761 > 1.000265957x > StringIndexOf.success 9.186 9.713 > 1.057369911x > StringIndexOf.successBig14.34146.343 > 3.231504079x > StringIndexOfChar.latin1_AVX2_String6220.918 12154.52 > 1.953814533x > StringIndexOfChar.latin1_AVX2_char 5503.556 5540.044 > 1.006629895x > StringIndexOfChar.latin1_SSE4_String6978.854 6818.689 > 0.977049957x > StringIndexOfChar.latin1_SSE4_char 5657.499 5474.624 > 0.967675646x > StringIndexOfChar.latin1_Short_String 7132.541 6863.359 > 0.962260014x > StringIndexOfChar.latin1_Short_char 16013.389 16162.437 > 1.009307711x > StringIndexOfChar.latin1_mixed_String 7386.12314771.622 > 1.15517x > StringIndexOfChar.latin1_mixed_char 9901.671 9782.245 > 0.987938803 Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision: Revert last change to IndexOf.java - Changes: - all: https://git.openjdk.org/jdk/pull/16753/files - new: https://git.openjdk.org/jdk/pull/16753/files/f4eefe1a..ed4451d1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16753&range=26 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16753&range=25-26 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/16753.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16753/head:pull/16753 PR: https://git.openjdk.org/jdk/pull/16753
