Re: RFR: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs

2023-11-30 Thread Jorn Vernee 
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee  wrote:

> This test is problematic on Zero due to 
> https://bugs.openjdk.org/browse/JDK-8321064
> 
> Disable it for now on that platform, until a Zero maintainer has a chance to 
> look into it.
> 
> Testing: running TestHandshake on zero to see that it is skipped.

Thanks for the reviews. I'll integrate this since it's trivial, and to quiet CI.

-

PR Comment: https://git.openjdk.org/jdk/pull/16906#issuecomment-1834120742

Re: RFR: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs

2023-11-30 Thread Aleksey Shipilev 
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee  wrote:

> This test is problematic on Zero due to 
> https://bugs.openjdk.org/browse/JDK-8321064
> 
> Disable it for now on that platform, until a Zero maintainer has a chance to 
> look into it.
> 
> Testing: running TestHandshake on zero to see that it is skipped.

Marked as reviewed by shade (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/16906#pullrequestreview-1757865043

Re: RFR: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs

2023-11-30 Thread Jorn Vernee 
On Thu, 30 Nov 2023 16:14:37 GMT, Aleksey Shipilev  wrote:

> Hold on, can we figure out if Zero can actually be fixed before we go and 
> disable the test? I think we only disable the tests like this if there is an 
> intrinsic reason why the test does not apply to a platform.

I would problem list it, but we can't problem list tests specifically on Zero.

The issue seems to be in Zero not polling for safepoints enough. See some 
discussion on: https://bugs.openjdk.org/browse/JDK-8321064

-

PR Comment: https://git.openjdk.org/jdk/pull/16906#issuecomment-1834092904

Re: RFR: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs

2023-11-30 Thread Aleksey Shipilev 
On Thu, 30 Nov 2023 16:18:42 GMT, Jorn Vernee  wrote:

> > Hold on, can we figure out if Zero can actually be fixed before we go and 
> > disable the test? I think we only disable the tests like this if there is 
> > an intrinsic reason why the test does not apply to a platform.
> 
> I would problem list it, but we can't problem list tests specifically on Zero.

Ah, that is unfortunate. Lacking problem-list support, disabling the test with 
`@requires` is okay.

-

PR Comment: https://git.openjdk.org/jdk/pull/16906#issuecomment-1834096799

Re: RFR: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs

2023-11-30 Thread Aleksey Shipilev 
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee  wrote:

> This test is problematic on Zero due to 
> https://bugs.openjdk.org/browse/JDK-8321064
> 
> Disable it for now on that platform, until a Zero maintainer has a chance to 
> look into it.
> 
> Testing: running TestHandshake on zero to see that it is skipped.

Hold on, can we figure out if Zero can actually be fixed before we go and 
disable the test? I think we only disable the tests like this if there is an 
intrinsic reason why the test does not apply to a platform.

-

PR Comment: https://git.openjdk.org/jdk/pull/16906#issuecomment-1834084558

Re: RFR: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs

2023-11-30 Thread Erik Österlund 
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee  wrote:

> This test is problematic on Zero due to 
> https://bugs.openjdk.org/browse/JDK-8321064
> 
> Disable it for now on that platform, until a Zero maintainer has a chance to 
> look into it.
> 
> Testing: running TestHandshake on zero to see that it is skipped.

Looks good.

-

Marked as reviewed by eosterlund (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16906#pullrequestreview-1757842529

RFR: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs

2023-11-30 Thread Jorn Vernee 
This test is problematic on Zero due to 
https://bugs.openjdk.org/browse/JDK-8321064

Disable it for now on that platform, until a Zero maintainer has a chance to 
look into it.

Testing: running TestHandshake on zero to see that it is skipped.

-

Commit messages:
 - disable TestHandshake on zero

Changes: https://git.openjdk.org/jdk/pull/16906/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16906&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8321119
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/16906.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16906/head:pull/16906

PR: https://git.openjdk.org/jdk/pull/16906