Re: RFR: 8321470: ThreadLocal.nextHashCode can be static final [v2]

2023-12-07 Thread Aleksey Shipilev 
On Wed, 6 Dec 2023 17:42:47 GMT, Brett Okken  wrote:

>> The static AtomicInteger used for the nextHashCode should be final.
>
> Brett Okken has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update full name

@bokken, you are good to `/integrate`.

-

PR Comment: https://git.openjdk.org/jdk/pull/16987#issuecomment-1845016772

Re: RFR: 8321470: ThreadLocal.nextHashCode can be static final [v2]

2023-12-06 Thread Jaikiran Pai 
On Wed, 6 Dec 2023 17:42:47 GMT, Brett Okken  wrote:

>> The static AtomicInteger used for the nextHashCode should be final.
>
> Brett Okken has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update full name

The change looks fine to me.

-

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16987#pullrequestreview-1769179862

Re: RFR: 8321470: ThreadLocal.nextHashCode can be static final [v2]

2023-12-06 Thread Brett Okken 
> The static AtomicInteger used for the nextHashCode should be final.

Brett Okken has updated the pull request incrementally with one additional 
commit since the last revision:

  Update full name

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/16987/files
  - new: https://git.openjdk.org/jdk/pull/16987/files/9e276138..d05272a3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=16987=01
 - incr: https://webrevs.openjdk.org/?repo=jdk=16987=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/16987.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16987/head:pull/16987

PR: https://git.openjdk.org/jdk/pull/16987

Re: RFR: 8321470: ThreadLocal.nextHashCode can be static final

2023-12-06 Thread Aleksey Shipilev 
On Wed, 6 Dec 2023 00:52:48 GMT, Brett Okken  wrote:

> The static AtomicInteger used for the nextHashCode should be final.

Looks okay to me!

Since this is new contribution, I would like someone else to take a look.

-

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16987#pullrequestreview-1768229984

Re: RFR: 8321470: ThreadLocal.nextHashCode can be static final

2023-12-06 Thread Aleksey Shipilev 
On Wed, 6 Dec 2023 00:52:48 GMT, Brett Okken  wrote:

> The static AtomicInteger used for the nextHashCode should be final.

Submitted: https://bugs.openjdk.org/browse/JDK-8321470

Please change this PR title to "8321470: ThreadLocal.nextHashCode can be static 
final", and bots would do the rest.

-

PR Comment: https://git.openjdk.org/jdk/pull/16987#issuecomment-1842976493

RFR: 8321470: ThreadLocal.nextHashCode can be static final

2023-12-06 Thread Brett Okken 
The static AtomicInteger used for the nextHashCode should be final.

-

Commit messages:
 - Merge remote-tracking branch 'upstream/master' into threadlocal_final
 - make ThreadLocal.nextHashCode final

Changes: https://git.openjdk.org/jdk/pull/16987/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk=16987=00
  Issue: https://bugs.openjdk.org/browse/JDK-8321470
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/16987.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16987/head:pull/16987

PR: https://git.openjdk.org/jdk/pull/16987