Re: [jdk22] RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
On Thu, 18 Jan 2024 15:36:07 GMT, Albert Mingkun Yang wrote: >> A trivial fix to disable core file generation in >> java/foreign/critical/TestCriticalUpcall.java. > > Marked as reviewed by ayang (Reviewer). @albertnetymk - Thanks for the fast review! - PR Comment: https://git.openjdk.org/jdk22/pull/90#issuecomment-1898718533
Re: [jdk22] RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
On Thu, 18 Jan 2024 15:20:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to disable core file generation in > java/foreign/critical/TestCriticalUpcall.java. Marked as reviewed by ayang (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/90#pullrequestreview-1829973047
[jdk22] RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
A trivial fix to disable core file generation in java/foreign/critical/TestCriticalUpcall.java. - Commit messages: - Backport a22ae909bc53344afd9bb6b1f08ff06858c10820 Changes: https://git.openjdk.org/jdk22/pull/90/files Webrev: https://webrevs.openjdk.org/?repo=jdk22=90=00 Issue: https://bugs.openjdk.org/browse/JDK-8321938 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk22.git pull/90/head:pull/90 PR: https://git.openjdk.org/jdk22/pull/90
Re: RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file [v2]
On Thu, 18 Jan 2024 07:47:54 GMT, David Holmes wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright year. > > Good and trivial. > > Copyright year needs updating. > > Thanks @dholmes-ora - Thanks for the review. Copyright year updated. - PR Comment: https://git.openjdk.org/jdk/pull/17476#issuecomment-1898458868
Re: RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file [v2]
> A trivial fix to disable core file generation in > java/foreign/critical/TestCriticalUpcall.java. Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision: Update copyright year. - Changes: - all: https://git.openjdk.org/jdk/pull/17476/files - new: https://git.openjdk.org/jdk/pull/17476/files/44ddcbb8..1982e5bd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17476=01 - incr: https://webrevs.openjdk.org/?repo=jdk=17476=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17476.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17476/head:pull/17476 PR: https://git.openjdk.org/jdk/pull/17476
Re: RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
On Thu, 18 Jan 2024 00:58:49 GMT, Daniel D. Daugherty wrote: > A trivial fix to disable core file generation in > java/foreign/critical/TestCriticalUpcall.java. Good and trivial. Copyright year needs updating. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17476#pullrequestreview-1829051168
RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file
A trivial fix to disable core file generation in java/foreign/critical/TestCriticalUpcall.java. - Commit messages: - 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file Changes: https://git.openjdk.org/jdk/pull/17476/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17476=00 Issue: https://bugs.openjdk.org/browse/JDK-8321938 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17476.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17476/head:pull/17476 PR: https://git.openjdk.org/jdk/pull/17476
