Re: [jdk22] RFR: 8323571: Regression in source resolution process
On Thu, 11 Jan 2024 22:56:38 GMT, Joe Wang wrote: > Backport to fix the regression introduced in JDK 22. Verified changes same as those in main-line. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/63#pullrequestreview-1817021441
Re: [jdk22] RFR: 8323571: Regression in source resolution process
On Thu, 11 Jan 2024 22:56:38 GMT, Joe Wang wrote: > Backport to fix the regression introduced in JDK 22. Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/63#pullrequestreview-1817006707
[jdk22] RFR: 8323571: Regression in source resolution process
Backport to fix the regression introduced in JDK 22. - Commit messages: - Backport e4389d8dc224419b8c1ee08e9f2dea0f103c6845 Changes: https://git.openjdk.org/jdk22/pull/63/files Webrev: https://webrevs.openjdk.org/?repo=jdk22=63=00 Issue: https://bugs.openjdk.org/browse/JDK-8323571 Stats: 357 lines in 4 files changed: 339 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jdk22/pull/63.diff Fetch: git fetch https://git.openjdk.org/jdk22.git pull/63/head:pull/63 PR: https://git.openjdk.org/jdk22/pull/63
Re: RFR: 8323571: Regression in source resolution process [v2]
> Fix a regression in the source resolution process where it failed to > recognize a custom InputSource when both the public and system IDs are null. > The particular issue is fixed at line 1233, the rest of the changes is > formatting to make the null-check on InputSource the first. > > Test is provided by Marc, thanks Marc! > (https://github.com/junit-team/junit5/issues/3594) > > XML tests, including the new test, pass with this change. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Fix copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/17377/files - new: https://git.openjdk.org/jdk/pull/17377/files/2eb23440..010c5db8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17377=01 - incr: https://webrevs.openjdk.org/?repo=jdk=17377=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/17377.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17377/head:pull/17377 PR: https://git.openjdk.org/jdk/pull/17377
Re: RFR: 8323571: Regression in source resolution process [v2]
On Thu, 11 Jan 2024 20:35:33 GMT, Naoto Sato wrote: > LGTM. If the file was modified this year, put 2024 in the header Copyright year fixed. Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/17377#issuecomment-1887951201
Re: RFR: 8323571: Regression in source resolution process
On Thu, 11 Jan 2024 18:36:39 GMT, Joe Wang wrote: > Fix a regression in the source resolution process where it failed to > recognize a custom InputSource when both the public and system IDs are null. > The particular issue is fixed at line 1233, the rest of the changes is > formatting to make the null-check on InputSource the first. > > Test is provided by Marc, thanks Marc! > (https://github.com/junit-team/junit5/issues/3594) > > XML tests, including the new test, pass with this change. LGTM. If the file was modified this year, put 2024 in the header - Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17377#pullrequestreview-1816602664
Re: RFR: 8323571: Regression in source resolution process
On Thu, 11 Jan 2024 18:36:39 GMT, Joe Wang wrote: > Fix a regression in the source resolution process where it failed to > recognize a custom InputSource when both the public and system IDs are null. > The particular issue is fixed at line 1233, the rest of the changes is > formatting to make the null-check on InputSource the first. > > Test is provided by Marc, thanks Marc! > (https://github.com/junit-team/junit5/issues/3594) > > XML tests, including the new test, pass with this change. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17377#pullrequestreview-1816320558
RFR: 8323571: Regression in source resolution process
Fix a regression in the source resolution process where it failed to recognize a custom InputSource when both the public and system IDs are null. The particular issue is fixed at line 1233, the rest of the changes is formatting to make the null-check on InputSource the first. Test is provided by Marc, thanks Marc! (https://github.com/junit-team/junit5/issues/3594) XML tests, including the new test, pass with this change. - Commit messages: - 8323571: Regression in source resolution process Changes: https://git.openjdk.org/jdk/pull/17377/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17377=00 Issue: https://bugs.openjdk.org/browse/JDK-8323571 Stats: 355 lines in 4 files changed: 339 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk/pull/17377.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17377/head:pull/17377 PR: https://git.openjdk.org/jdk/pull/17377
