Re: RFR: 8326461: tools/jlink/CheckExecutable.java fail after JDK-8325342
On Thu, 22 Feb 2024 07:23:04 GMT, SendaoYan wrote: > Before JDK-8325342(commit id:0bcece995840777db660811e4b20bb018e90439b), all > the files in build/linux-x86_64-server-release/images/jdk/bin are executable: > >  > > > After JDK-8325342, all the *.debuginfo files in > build/linux-x86_64-server-release/images/jdk/bin are not executable: > >  > > > This PR only modifies the testcase to adapt to the modification of the > corresponding build script, ignoring the check of debuginfo file executable > permissions, and the risk is low Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17958#pullrequestreview-1895258187
Re: RFR: 8326461: tools/jlink/CheckExecutable.java fail after JDK-8325342
On Thu, 22 Feb 2024 07:23:04 GMT, SendaoYan wrote: > Before JDK-8325342(commit id:0bcece995840777db660811e4b20bb018e90439b), all > the files in build/linux-x86_64-server-release/images/jdk/bin are executable: > >  > > > After JDK-8325342, all the *.debuginfo files in > build/linux-x86_64-server-release/images/jdk/bin are not executable: > >  > > > This PR only modifies the testcase to adapt to the modification of the > corresponding build script, ignoring the check of debuginfo file executable > permissions, and the risk is low Looks fine to me. - Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17958#pullrequestreview-1895241663
Re: RFR: 8326461: tools/jlink/CheckExecutable.java fail after JDK-8325342
On Thu, 22 Feb 2024 07:23:04 GMT, SendaoYan wrote: > Before JDK-8325342(commit id:0bcece995840777db660811e4b20bb018e90439b), all > the files in build/linux-x86_64-server-release/images/jdk/bin are executable: > >  > > > After JDK-8325342, all the *.debuginfo files in > build/linux-x86_64-server-release/images/jdk/bin are not executable: > >  > > > This PR only modifies the testcase to adapt to the modification of the > corresponding build script, ignoring the check of debuginfo file executable > permissions, and the risk is low JDK-8326412 changed the executable bit on the debuginfo files but forgot to update this test. - PR Comment: https://git.openjdk.org/jdk/pull/17958#issuecomment-1958947943
RFR: 8326461: tools/jlink/CheckExecutable.java fail after JDK-8325342
Before JDK-8325342(commit id:0bcece995840777db660811e4b20bb018e90439b), all the files in build/linux-x86_64-server-release/images/jdk/bin are executable:  After JDK-8325342, all the *.debuginfo files in build/linux-x86_64-server-release/images/jdk/bin are not executable:  This PR only modifies the testcase to adapt to the modification of the corresponding build script, ignoring the check of debuginfo file executable permissions, and the risk is low - Commit messages: - 8326461: tools/jlink/CheckExecutable.java fail after JDK-8325342 Changes: https://git.openjdk.org/jdk/pull/17958/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17958&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326461 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17958.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17958/head:pull/17958 PR: https://git.openjdk.org/jdk/pull/17958
