Re: RFR: 8326714: Make file-local functions static in src/java.base/unix/native/libjava/childproc.c
On Tue, 27 Feb 2024 07:29:46 GMT, Daniel Jeliński wrote: >> Please help review this trivial change. This was branched from >> https://github.com/openjdk/jdk/pull/18013, based on discussion with >> @plummercj in https://github.com/openjdk/jdk/pull/18013 comments. Thanks > > LGTM @djelinski @RogerRiggs Thanks for the reviews. - PR Comment: https://git.openjdk.org/jdk/pull/18019#issuecomment-1966903722
Re: RFR: 8326714: Make file-local functions static in src/java.base/unix/native/libjava/childproc.c
On Tue, 27 Feb 2024 03:11:37 GMT, Jiangli Zhou wrote: > Please help review this trivial change. This was branched from > https://github.com/openjdk/jdk/pull/18013, based on discussion with > @plummercj in https://github.com/openjdk/jdk/pull/18013 comments. Thanks Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18019#pullrequestreview-1903727632
Re: RFR: 8326714: Make file-local functions static in src/java.base/unix/native/libjava/childproc.c
On Tue, 27 Feb 2024 03:11:37 GMT, Jiangli Zhou wrote: > Please help review this trivial change. This was branched from > https://github.com/openjdk/jdk/pull/18013, based on discussion with > @plummercj in https://github.com/openjdk/jdk/pull/18013 comments. Thanks LGTM - Marked as reviewed by djelinski (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18019#pullrequestreview-1902717059
RFR: 8326714: Make file-local functions static in src/java.base/unix/native/libjava/childproc.c
Please help review this trivial change. This was branched from https://github.com/openjdk/jdk/pull/18013, based on discussion with @plummercj in https://github.com/openjdk/jdk/pull/18013 comments. Thanks - Commit messages: - 8326714: Make file-local functions static in src/java.base/unix/native/libjava/childproc.c Changes: https://git.openjdk.org/jdk/pull/18019/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18019=00 Issue: https://bugs.openjdk.org/browse/JDK-8326714 Stats: 20 lines in 2 files changed: 0 ins; 13 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/18019.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18019/head:pull/18019 PR: https://git.openjdk.org/jdk/pull/18019
