Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]
> Fixing test cases. For bad test cases, only the first case was run, and the > rest were ignored. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Reflects review comments - Changes: - all: https://git.openjdk.org/jdk/pull/18113/files - new: https://git.openjdk.org/jdk/pull/18113/files/4c80fe5c..c67ecc32 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18113&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18113&range=00-01 Stats: 16 lines in 2 files changed: 0 ins; 2 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/18113.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18113/head:pull/18113 PR: https://git.openjdk.org/jdk/pull/18113
Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18113#pullrequestreview-1917711954
Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments Marked as reviewed by jlu (Committer). - PR Review: https://git.openjdk.org/jdk/pull/18113#pullrequestreview-1917856118
Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments +1 - Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18113#pullrequestreview-1917870069
Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18113#pullrequestreview-1917875583
Re: RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases [v2]
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote: >> Fixing test cases. For bad test cases, only the first case was run, and the >> rest were ignored. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/18113#issuecomment-1981238638
