Re: RFR: 8327675: jspawnhelper should be built on all unix platforms
On Fri, 8 Mar 2024 13:58:25 GMT, Erik Joelsson wrote: > Looks good, but why are the tests failing? **macos-x64 / test (langtools/tier1)** fails when installing homebrew: Error: Failure while executing; `/usr/bin/env /usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --user-agent Homebrew/4.2.9\ (Macintosh;\ Intel\ Mac\ OS\ X\ 13.6.4)\ curl/8.4.0 --header Accept-Language:\ en --fail --progress-bar --silent --remote-time --output /Users/runner/Library/Caches/Homebrew/api/formula.jws.json --location --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.2.9\ (Macintosh;\ Intel\ Mac\ OS\ X\ 13.6.4)\ curl/8.4.0 --header Accept-Language:\ en --fail --progress-bar --silent --compressed --speed-limit 100 --speed-time 5 [https://formulae.brew.sh/api/formula.jws.json`](https://formulae.brew.sh/api/formula.jws.json%60) exited with 28. Here's the output: curl: (28) Operation too slow. Less than 100 bytes/sec transferred the last 5 seconds **linux-cross-compile / build (riscv64)** fails when installing the sysroot: W: Failure while configuring base packages. This will be re-attempted up to five times. W: See /home/runner/work/jdk/jdk/sysroot/debootstrap/debootstrap.log for details (possibly the package libpng16-16:riscv64 is at fault) **linux-x86 / test (jdk/tier1 part 2)** fails on [java/util/Collections/RotateHuge](https://github.com/magicus/jdk/actions/runs/8201858400#summary-22432420637): (🤷 ???) 💥 Test failures summary These tests reported errors: [java/util/Collections/RotateHuge](https://github.com/magicus/jdk/actions/runs/8201858400#user-content-java_util_collections_rotatehuge) I'd say that's just GHA for ya... - PR Comment: https://git.openjdk.org/jdk/pull/18165#issuecomment-1985779398
Re: RFR: 8327675: jspawnhelper should be built on all unix platforms
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote: > We should match the building of jspawnhelper in > make/modules/java.base/Launcher.gmk with the usage for all unix platforms in > src/java.base/unix/classes/java/lang/ProcessImpl.java. > > Granted, the list of OSes in the makefile amounts to the current list of all > Unix OSes in the JDK, but there is no need to have this logical disparity. > > This was inspired by the discovery in > https://github.com/openjdk/jdk/pull/18112#discussion_r1517455696. Looks good, but why are the tests failing? - Marked as reviewed by erikj (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18165#pullrequestreview-1924937739
Re: RFR: 8327675: jspawnhelper should be built on all unix platforms
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote: > We should match the building of jspawnhelper in > make/modules/java.base/Launcher.gmk with the usage for all unix platforms in > src/java.base/unix/classes/java/lang/ProcessImpl.java. > > Granted, the list of OSes in the makefile amounts to the current list of all > Unix OSes in the JDK, but there is no need to have this logical disparity. > > This was inspired by the discovery in > https://github.com/openjdk/jdk/pull/18112#discussion_r1517455696. +1 - Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18165#pullrequestreview-1924593320
Re: RFR: 8327675: jspawnhelper should be built on all unix platforms
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote: > We should match the building of jspawnhelper in > make/modules/java.base/Launcher.gmk with the usage for all unix platforms in > src/java.base/unix/classes/java/lang/ProcessImpl.java. > > Granted, the list of OSes in the makefile amounts to the current list of all > Unix OSes in the JDK, but there is no need to have this logical disparity. > > This was inspired by the discovery in > https://github.com/openjdk/jdk/pull/18112#discussion_r1517455696. Looks good! - Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18165#pullrequestreview-1924580539
RFR: 8327675: jspawnhelper should be built on all unix platforms
We should match the building of jspawnhelper in make/modules/java.base/Launcher.gmk with the usage for all unix platforms in src/java.base/unix/classes/java/lang/ProcessImpl.java. Granted, the list of OSes in the makefile amounts to the current list of all Unix OSes in the JDK, but there is no need to have this logical disparity. This was inspired by the discovery in https://github.com/openjdk/jdk/pull/18112#discussion_r1517455696. - Commit messages: - 8327675: jspawnhelper should be built on all unix platforms Changes: https://git.openjdk.org/jdk/pull/18165/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18165&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327675 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18165.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18165/head:pull/18165 PR: https://git.openjdk.org/jdk/pull/18165
