Re: RFR: 8327994: Update code gen in CallGeneratorHelper [v2]
On Wed, 20 Mar 2024 17:49:51 GMT, Maurizio Cimadamore wrote: > No changes in libTestDowncallStack.c (not even minor ones) ? No, there was a 'missing' space between the prefix parameters and the actual parameters of the stack variants, and between the arguments passed when that callback was called in the upcall lib (So, white space only). libTestDowncall.c didn't have any changes. - PR Comment: https://git.openjdk.org/jdk/pull/18269#issuecomment-2010825750
Re: RFR: 8327994: Update code gen in CallGeneratorHelper [v2]
On Sat, 16 Mar 2024 22:34:25 GMT, Jorn Vernee wrote: >> Update the code gen code in CallGeneratorHelper to reflect the latest state >> of the libTest(Downcall/Upcall)(Stack).c and shared.h files. >> >> - The previous code wanted users to pipe stdout into a file. But, since we >> have 5 files that need to be created, and the names of those files is >> important too, I've changed the script to write to those files directly >> instead. >> - I moved the definition of `S_` to libVarArgs.c where it's used, as >> it's not actually generated by CallGeneratorHelper. >> - GitHub doesn't render the changes to some of the files, but those files >> only contain either white space changes (some missing spaces after `,`), and >> copyright header updates. > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision: > > Delete extra space > > Co-authored-by: Andrey Turbanov Nice cleanup. No changes in libTestDowncallStack.c (not even minor ones) ? - Marked as reviewed by mcimadamore (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18269#pullrequestreview-1949642772
Re: RFR: 8327994: Update code gen in CallGeneratorHelper [v2]
> Update the code gen code in CallGeneratorHelper to reflect the latest state > of the libTest(Downcall/Upcall)(Stack).c and shared.h files. > > - The previous code wanted users to pipe stdout into a file. But, since we > have 5 files that need to be created, and the names of those files is > important too, I've changed the script to write to those files directly > instead. > - I moved the definition of `S_` to libVarArgs.c where it's used, as it's > not actually generated by CallGeneratorHelper. > - GitHub doesn't render the changes to some of the files, but those files > only contain either white space changes (some missing spaces after `,`), and > copyright header updates. Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: Delete extra space Co-authored-by: Andrey Turbanov - Changes: - all: https://git.openjdk.org/jdk/pull/18269/files - new: https://git.openjdk.org/jdk/pull/18269/files/e66b7671..d282ecbd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18269&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18269&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18269.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18269/head:pull/18269 PR: https://git.openjdk.org/jdk/pull/18269
Re: RFR: 8327994: Update code gen in CallGeneratorHelper [v2]
On Sat, 16 Mar 2024 15:41:06 GMT, Jorn Vernee wrote:
>> Update the code gen code in CallGeneratorHelper to reflect the latest state
>> of the libTest(Downcall/Upcall)(Stack).c and shared.h files.
>>
>> - The previous code wanted users to pipe stdout into a file. But, since we
>> have 5 files that need to be created, and the names of those files is
>> important too, I've changed the script to write to those files directly
>> instead.
>> - I moved the definition of `S_` to libVarArgs.c where it's used, as
>> it's not actually generated by CallGeneratorHelper.
>> - GitHub doesn't render the changes to some of the files, but those files
>> only contain either white space changes (some missing spaces after `,`), and
>> copyright header updates.
>
> Jorn Vernee has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Delete extra space
>
> Co-authored-by: Andrey Turbanov
test/jdk/java/foreign/CallGeneratorHelper.java line 195:
> 193: }
> 194:
> 195: private static void generateStructDecl(PrintStream out,
> List fields) {
Suggestion:
private static void generateStructDecl(PrintStream out,
List fields) {
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18269#discussion_r1527165383
RFR: 8327994: Update code gen in CallGeneratorHelper
Update the code gen code in CallGeneratorHelper to reflect the latest state of the libTest(Downcall/Upcall)(Stack).c and shared.h files. - The previous code wanted users to pipe stdout into a file. But, since we have 5 files that need to be created, and the names of those files is important too, I've changed the script to write to those files directly instead. - I moved the definition of `S_` to libVarArgs.c where it's used, as it's not actually generated by CallGeneratorHelper. - GitHub doesn't render the changes to some of the files, but those files only contain either white space changes (some missing spaces after `,`), and copyright header updates. - Commit messages: - add more run instructions - simplify - use export.h - factor out some shared code - fix test file generation - remove dead code from CallGeneratorHelper Changes: https://git.openjdk.org/jdk/pull/18269/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18269&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327994 Stats: 36078 lines in 6 files changed: 62 ins; 40 del; 35976 mod Patch: https://git.openjdk.org/jdk/pull/18269.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18269/head:pull/18269 PR: https://git.openjdk.org/jdk/pull/18269
