Re: RFR: 8328261: public lookup fails with IllegalAccessException when used while module system is being initialized

2024-03-18 Thread Alan Bateman
On Mon, 18 Mar 2024 17:40:26 GMT, Mandy Chung  wrote:

> A simple fix.   This is caused by a bug in `VerifyAccess::isClassAccessible` 
> that checks if a class is exported from `java.base` before the exports are 
> fully setup.It should check if the module system is fully initialized 
> before checking the module exports instead.

Marked as reviewed by alanb (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18356#pullrequestreview-1944755743


Re: RFR: 8328261: public lookup fails with IllegalAccessException when used while module system is being initialized

2024-03-18 Thread Roger Riggs
On Mon, 18 Mar 2024 17:40:26 GMT, Mandy Chung  wrote:

> A simple fix.   This is caused by a bug in `VerifyAccess::isClassAccessible` 
> that checks if a class is exported from `java.base` before the exports are 
> fully setup.It should check if the module system is fully initialized 
> before checking the module exports instead.

LGTM

-

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18356#pullrequestreview-1943799289


RFR: 8328261: public lookup fails with IllegalAccessException when used while module system is being initialized

2024-03-18 Thread Mandy Chung
A simple fix.   This is caused by a bug in `VerifyAccess::isClassAccessible` 
that checks if a class is exported from `java.base` before the exports are 
fully setup.It should check if the module system is fully initialized 
before checking the module exports instead.

-

Commit messages:
 - 8328261: public lookup fails with IllegalAccessException when used while 
module system is being initialized

Changes: https://git.openjdk.org/jdk/pull/18356/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18356&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328261
  Stats: 9 lines in 1 file changed: 1 ins; 5 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18356.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18356/head:pull/18356

PR: https://git.openjdk.org/jdk/pull/18356