Re: RFR: 8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing [v3]

[Matthias Baesken]

On Fri, 19 Apr 2024 09:20:27 GMT, Christoph Langer  wrote:

> This trace seems a bit unsymmetric to its Windows counterpart. Maybe it 
> should be left out here, too, since there is tracing in GetJREPath.

I removed the JLI trace output for the launcher exe path.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/18699#discussion_r1572140833

Re: RFR: 8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing [v3]

[Christoph Langer]

On Thu, 18 Apr 2024 06:57:05 GMT, Matthias Baesken  wrote:

>> We have already good JLI tracing capabilities. But GetApplicationHome and 
>> GetApplicationHomeFromDll lack some tracing and should be enhanced.
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   remove obsolete USE_REGISTRY_LOOKUP usages

src/java.base/unix/native/libjli/java_md_common.c line 85:

> 83: const char *execname = GetExecName();
> 84: if (execname != NULL) {
> 85: JLI_TraceLauncher("Launcher executable path is %s\n", execname);

This trace seems a bit unsymmetric to its Windows counterpart. Maybe it should 
be left out here, too, since there is tracing in GetJREPath.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/18699#discussion_r1572086726

Re: RFR: 8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing [v3]

[Matthias Baesken]

On Thu, 18 Apr 2024 06:31:03 GMT, Alan Bateman  wrote:

>> Hi Christoph, seems the USE_REGISTRY_LOOKUP is currently unused  (at least 
>> without additional defines that are not present usually) 
>> 
>> src/java.base/windows/native/libjli/java_md.c:52:#ifdef USE_REGISTRY_LOOKUP
>> src/java.base/windows/native/libjli/java_md.c:333:#ifdef USE_REGISTRY_LOOKUP
>> 
>> 
>> I am not sure if this even works any more.  Maybe Alan could comment on this 
>> ?
>
> @MBaesken I checked into the building with -DUSE_REGISTRY_LOOKUP as that 
> compiled in code that the Oracle installer needed when it copied java.exe to 
> somewhere. This is indeed left over code and can be removed from java_md.c.

Hi Alan, thanks for checking this !
I removed the USE_REGISTRY_LOOKUP usages.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/18699#discussion_r1570109527

Re: RFR: 8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing [v3]

[Matthias Baesken]

> We have already good JLI tracing capabilities. But GetApplicationHome and 
> GetApplicationHomeFromDll lack some tracing and should be enhanced.

Matthias Baesken has updated the pull request incrementally with one additional 
commit since the last revision:

  remove obsolete USE_REGISTRY_LOOKUP usages

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/18699/files
  - new: https://git.openjdk.org/jdk/pull/18699/files/344d1b89..ddb3e0fe

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18699&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18699&range=01-02

  Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18699.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18699/head:pull/18699

PR: https://git.openjdk.org/jdk/pull/18699