Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute [v2]

2024-04-26 Thread Raffaello Giulietti 
On Fri, 26 Apr 2024 01:35:56 GMT, Joe Darcy  wrote:

>> Remove unnecessary setting of variable y, found by an IDE inspection noted 
>> in the bug report.
>
> Joe Darcy has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update copyright year.

Marked as reviewed by rgiulietti (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18963#pullrequestreview-2024512783

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute [v2]

2024-04-25 Thread Joe Darcy 
> Remove unnecessary setting of variable y, found by an IDE inspection noted in 
> the bug report.

Joe Darcy has updated the pull request incrementally with one additional commit 
since the last revision:

  Update copyright year.

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/18963/files
  - new: https://git.openjdk.org/jdk/pull/18963/files/e8f5c334..f0ed7d5f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18963&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18963&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18963.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18963/head:pull/18963

PR: https://git.openjdk.org/jdk/pull/18963

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Brian Burkhalter 
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy  wrote:

> Remove unnecessary setting of variable y, found by an IDE inspection noted in 
> the bug report.

Marked as reviewed by bpb (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18963#pullrequestreview-2023708504

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Naoto Sato 
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy  wrote:

> Remove unnecessary setting of variable y, found by an IDE inspection noted in 
> the bug report.

Marked as reviewed by naoto (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18963#pullrequestreview-2023687212

RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Joe Darcy 
Remove unnecessary setting of variable y, found by an IDE inspection noted in 
the bug report.

-

Commit messages:
 - JDK-8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

Changes: https://git.openjdk.org/jdk/pull/18963/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18963&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331108
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18963.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18963/head:pull/18963

PR: https://git.openjdk.org/jdk/pull/18963

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Joe Darcy 
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy  wrote:

> Remove unnecessary setting of variable y, found by an IDE inspection noted in 
> the bug report.

All Math and StrictMath regression tests pass with this change. Examining the 
code, y does look to be overwritten on all the code paths where it factors into 
the returned result.

-

PR Comment: https://git.openjdk.org/jdk/pull/18963#issuecomment-2078210519