Re: RFR: 8331851: Add specific regression leap year tests for Calendar.roll()

2024-05-17 Thread Naoto Sato
On Wed, 15 May 2024 09:39:16 GMT, serhiysachkov  wrote:

> Add specific regression tests for Calendar.roll() method to explicitly 
> various leap year test scenarios. This is inspired by the ambiguity which 
> occurred in leap year unaware test creation as in case with Calendar.add() in 
> swing component test case as detailed in 
> (https://bugs.openjdk.org/browse/JDK-8327088).

LGTM. I might want to remove those test case names as they are apparent from 
the parameters, but it's OK.

-

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19247#pullrequestreview-2064330497


RFR: 8331851: Add specific regression leap year tests for Calendar.roll()

2024-05-15 Thread serhiysachkov
Add specific regression tests for Calendar.roll() method to explicitly various 
leap year test scenarios. This is inspired by the ambiguity which occurred in 
leap year unaware test creation as in case with Calendar.add() in swing 
component test case as detailed in 
(https://bugs.openjdk.org/browse/JDK-8327088).

-

Commit messages:
 - JDK-8331851 Add specific regression leap year tests for Calendar.roll()

Changes: https://git.openjdk.org/jdk/pull/19247/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19247&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331851
  Stats: 190 lines in 1 file changed: 190 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/19247.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19247/head:pull/19247

PR: https://git.openjdk.org/jdk/pull/19247