Re: RFR: 8332505: JEP 457: ClassRemapper forgets to remap bootstrap method references

2024-05-28 Thread Jan Lahoda
On Mon, 20 May 2024 08:03:28 GMT, Adam Sotona  wrote:

> Class-File API `ClassRemapper` component suppose to remap all classes 
> referenced in a class file.
> Actual implementation missed remapping of bootstrap methods referenced from 
> `invokedynamic` instructions.
> This patch fixes the remapping and adds relevant test.
> 
> Please review.
> 
> Thanks,
> Adam

Looks reasonable to me.

-

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19299#pullrequestreview-2082624013


RFR: 8332505: JEP 457: ClassRemapper forgets to remap bootstrap method references

2024-05-20 Thread Adam Sotona
Class-File API `ClassRemapper` component suppose to remap all classes 
referenced in a class file.
Actual implementation missed remapping of bootstrap methods referenced from 
`invokedynamic` instructions.
This patch fixes the remapping and adds relevant test.

Please review.

Thanks,
Adam

-

Commit messages:
 - 8332505: JEP 457: ClassRemapper forgets to remap bootstrap method references

Changes: https://git.openjdk.org/jdk/pull/19299/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19299=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332505
  Stats: 9 lines in 2 files changed: 4 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/19299.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19299/head:pull/19299

PR: https://git.openjdk.org/jdk/pull/19299