Re: RFR: 8332749: Broken link in MemorySegment.Scope.html

2024-05-23 Thread Magnus Ihse Bursie
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg  wrote:

> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.

The fix looks fine but the bug title sounds like you are modifying an html 
file...

-

PR Comment: https://git.openjdk.org/jdk/pull/19366#issuecomment-2127413592


Re: RFR: 8332749: Broken link in MemorySegment.Scope.html

2024-05-23 Thread Iris Clark
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg  wrote:

> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.

Marked as reviewed by iris (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/19366#pullrequestreview-2074232921


Re: RFR: 8332749: Broken link in MemorySegment.Scope.html

2024-05-23 Thread Per Minborg
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg  wrote:

> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.

Seams to work after the patch:

![image](https://github.com/openjdk/jdk/assets/7457876/6a48599b-0e08-40b0-938e-f7cb13b74ae6)

.../api/java.base/java/lang/foreign/MemorySegment.html#wrapping-addresses

-

PR Comment: https://git.openjdk.org/jdk/pull/19366#issuecomment-2126976574


RFR: 8332749: Broken link in MemorySegment.Scope.html

2024-05-23 Thread Per Minborg
This PR proposes to fix a broken link in the `MemorySegment.Scope` class.

-

Commit messages:
 - Fix link to section

Changes: https://git.openjdk.org/jdk/pull/19366/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19366=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332749
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19366.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19366/head:pull/19366

PR: https://git.openjdk.org/jdk/pull/19366