Re: RFR: 8332898: failure_handler: log directory of commands

2024-05-24 Thread Leonid Mesnik
On Fri, 24 May 2024 14:34:39 GMT, Ludvig Janiuk  wrote:

> Also log the directory in which the command used by failure_handler was 
> executed. While often the same, it isn't always, and so it this should 
> simplify troubleshooting for someone looking at this at a glance without 
> being a failure_handler expert.
> 
> Example output after this change:
> 
> 
> [2024-05-24 14:26:46] [/usr/bin/pmap, -p, 2233017] timeout=2 in 
> //JTwork/scratch
> 
> 
> before:
> 
> 
> [2024-05-24 14:26:46] [/usr/bin/pmap, -p, 2233017] timeout=2
> 

Marked as reviewed by lmesnik (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/19396#pullrequestreview-2077492691


RFR: 8332898: failure_handler: log directory of commands

2024-05-24 Thread Ludvig Janiuk
Also log the directory in which the command used by failure_handler was 
executed. While often the same, it isn't always, and so it this should simplify 
troubleshooting for someone looking at this at a glance without being a 
failure_handler expert.

Example output after this change:


[2024-05-24 14:26:46] [/usr/bin/pmap, -p, 2233017] timeout=2 in 
//JTwork/scratch


before:


[2024-05-24 14:26:46] [/usr/bin/pmap, -p, 2233017] timeout=2


-

Commit messages:
 - 8332898 failure_handler: log directory of commands

Changes: https://git.openjdk.org/jdk/pull/19396/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19396=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332898
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19396.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19396/head:pull/19396

PR: https://git.openjdk.org/jdk/pull/19396