Re: RFR: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails

2024-05-28 Thread Alexander Matveev 
On Tue, 28 May 2024 20:13:24 GMT, Alexey Semenyuk  wrote:

> Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to 
> the test descriptor

Looks good.

-

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19436#pullrequestreview-2083892285

Re: RFR: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails

2024-05-28 Thread Alexey Semenyuk 
On Tue, 28 May 2024 20:13:24 GMT, Alexey Semenyuk  wrote:

> Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to 
> the test descriptor

@sashamatveev please review

-

PR Comment: https://git.openjdk.org/jdk/pull/19436#issuecomment-2136094953

RFR: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails

2024-05-28 Thread Alexey Semenyuk 
Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to the 
test descriptor

-

Commit messages:
 - Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to 
test desc. It fixes the following error:

Changes: https://git.openjdk.org/jdk/pull/19436/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk=19436=00
  Issue: https://bugs.openjdk.org/browse/JDK-8333116
  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/19436.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19436/head:pull/19436

PR: https://git.openjdk.org/jdk/pull/19436